Skip to content

Support passing start-after parameter to list_objects#1138

Merged
zhenjiaseu merged 1 commit intoalibaba:release/0.9from
chenqi97:0.9/add_starts_after
Mar 4, 2026
Merged

Support passing start-after parameter to list_objects#1138
zhenjiaseu merged 1 commit intoalibaba:release/0.9from
chenqi97:0.9/add_starts_after

Conversation

@chenqi97
Copy link
Collaborator

@chenqi97 chenqi97 commented Mar 3, 2026

No description provided.

@CLAassistant
Copy link

CLAassistant commented Mar 3, 2026

CLA assistant check
All committers have signed the CLA.

@chenqi97 chenqi97 force-pushed the 0.9/add_starts_after branch from 97dfeb2 to 05872d2 Compare March 3, 2026 06:51
@lihuiba lihuiba requested a review from zhenjiaseu March 3, 2026 06:55
ecosystem/oss.h Outdated
uint8_t ver = 2;
bool slash_delimiter = false;
uint16_t max_keys = 0;
std::string_view start_after = "";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

= {};

int do_list_objects_v2(std::string_view bucket, std::string_view prefix,
ListObjectsCallback cb, bool delimiters, int maxKeys,
std::string* marker);
std::string* marker, std::string_view start_after = {});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need the default value

@chenqi97 chenqi97 force-pushed the 0.9/add_starts_after branch from 05872d2 to bd0cc69 Compare March 3, 2026 07:02
@chenqi97 chenqi97 force-pushed the 0.9/add_starts_after branch from bd0cc69 to 50c3535 Compare March 3, 2026 07:03
Copy link
Collaborator

@zhenjiaseu zhenjiaseu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhenjiaseu zhenjiaseu merged commit 94d074b into alibaba:release/0.9 Mar 4, 2026
12 checks passed
lihuiba pushed a commit that referenced this pull request Mar 4, 2026
Co-authored-by: Qi Chen <46185085+chenqi97@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants