refactor(cache): lazy initialize rwlock to reduce memory usage#1149
Open
xiaoyang-hhh wants to merge 1 commit intoalibaba:release/0.9from
Open
refactor(cache): lazy initialize rwlock to reduce memory usage#1149xiaoyang-hhh wants to merge 1 commit intoalibaba:release/0.9from
xiaoyang-hhh wants to merge 1 commit intoalibaba:release/0.9from
Conversation
Collaborator
|
given that you bind the life-cycle of rwlock to FileStore, is it possible to move the rwlock from LruEntry to FileStore? |
0a9319c to
87eef3f
Compare
87eef3f to
b32422d
Compare
Contributor
Author
The previous implementation had some issues. A cached file may correspond to multiple CacheStores meanwhile, so the rwlock is still kept in LruEntry, with its creation and destruction controlled by openCount. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change LruEntry::rw_lock_ from direct member to std::unique_ptr for lazy initialization in Full File Cache:
This reduces memory usage when there are many cache files, but only a small number of them are being read or written at any moment.