Add MiniMax copilot provider support#15484
Conversation
|
Thanks for the PR. I found one functional blocker: the new Please update the config controller and related tests to fully read/write the new fields. Another concern is the design direction. If Copilot is expected to support more models and providers, I think we should avoid extending this by only changing the frontend model list and adding more Since this changes the Copilot configuration contract, please also update the related specs/docs. The current integration spec still only documents Suggested follow-ups:
|
|
Thanks for your this PR. 🙏 感谢您提交的PR。 🙏 |
|
Thanks for the review. I replaced the provider-specific branch with a registry, persisted and returned the provider, protocol, region, and Base URL fields, added metadata-driven options for both target models, and updated the integration spec. I also added controller and model-factory coverage with real request-capture tests, then ran the scoped Java tests, Checkstyle/Spotless, both UI linters, type checks, and production builds. |
|
Thanks for the update. The previous functional blocker around config persistence looks fixed now: the controller returns/persists I still have two review concerns:
Given the security implications, I suggest we do not keep iterating code directly in this PR for now. It may be better to open an issue first and discuss the provider/baseUrl extension design there, including the security boundaries and configuration contract. After the approach is agreed, the implementation can be updated in one direction instead of repeatedly rewriting the code. |
Reason: add target provider/model to existing provider registry
Summary
MiniMax-M3andMiniMax-M2.7with OpenAI- and Anthropic-compatible endpoints for global and China regions.Test plan
./mvnw -q -pl copilot -am -DskipRat=true -Dcheckstyle.skip=true -Djacoco.skip=true -DskipITs -Dtest=CopilotModelProviderTest,CopilotPropertiesTest,CopilotAgentManagerTest -Dsurefire.failIfNoSpecifiedTests=false test./mvnw -q -pl console -am -DskipRat=true -Dcheckstyle.skip=true -Djacoco.skip=true -DskipITs -Dtest=ConsoleCopilotConfigControllerTest -Dsurefire.failIfNoSpecifiedTests=false test./mvnw -q -pl copilot,console -DskipTests checkstyle:check spotless:checkcd console-ui-next && ./node_modules/.bin/eslint src/pages/settingCenter/index.tsx && ./node_modules/.bin/tsc -b --pretty false && ./node_modules/.bin/vite buildcd console-ui && ./node_modules/.bin/eslint src/pages/SettingCenter/CopilotConfig.jscd console-ui && NODE_OPTIONS=--openssl-legacy-provider NODE_ENV=production ./node_modules/.bin/webpack --config build/webpack.prod.conf.js