refactor: replace GatedActType with ActivationType from flashinfer#782
Merged
refactor: replace GatedActType with ActivationType from flashinfer#782
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates flashinfer API usage to adopt the renamed ActivationType enum (replacing deprecated GatedActType) in the TRTLLM FP4 MoE executor and its tests.
Changes:
- Replace
GatedActTypeimports/usages withActivationType. - Reformat imports and some long expressions for readability.
- Adjust test logic/type hints to use
ActivationType.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| rtp_llm/models_py/modules/factory/fused_moe/impl/cuda/executors/trtllm_fp4_executor.py | Switch executor activation enum mapping from GatedActType to ActivationType and refactor formatting. |
| rtp_llm/models_py/modules/factory/fused_moe/impl/cuda/executors/test/trtllm_fp4_executor_test.py | Update tests/type hints to use ActivationType and refactor formatting/imports. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rtp_llm/models_py/modules/factory/fused_moe/impl/cuda/executors/trtllm_fp4_executor.py
Show resolved
Hide resolved
LLLLKKKK
previously approved these changes
Mar 16, 2026
Update flashinfer API usage to use the renamed ActivationType enum instead of the deprecated GatedActType in trtllm_fp4_executor and its test file. Made-with: Cursor
netaddi
force-pushed
the
update_flashinfer_0.6.4
branch
from
7db027d to
fb361bb
Compare
LLLLKKKK
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update flashinfer API usage to use the renamed ActivationType enum
instead of the deprecated GatedActType in trtllm_fp4_executor and its
test file.
Made-with: Cursor