Add GetWithFallback method to fallback non existent or expired keys#306
Open
Glebvvss wants to merge 1 commit intoallegro:mainfrom
Open
Add GetWithFallback method to fallback non existent or expired keys#306Glebvvss wants to merge 1 commit intoallegro:mainfrom
Glebvvss wants to merge 1 commit intoallegro:mainfrom
Conversation
Glebvvss
force-pushed
the
get_or_set_feature
branch
5 times, most recently
from
d92b26b to
470baf8
Compare
Glebvvss
force-pushed
the
get_or_set_feature
branch
from
470baf8 to
d2a0648
Compare
Glebvvss
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple feature, which can increase usability. After implementation we will not need to check key on existent before each time to use. It can help in situations when cached value can be expired after sometime and we need to recalculate new value, but for understand it we need to check key on existent and manually recalculate value. It can cost some amount lines of code or we can white that code incorrect