Conversation
|
if you find anyway to improve it please let me know! i tried a few things but can't seem to get it faster. |
|
I forgot to add the locked shard to the map fixing it made a big difference |
cristaloleg
left a comment
There was a problem hiding this comment.
Please reformat with gofmt
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #379 +/- ##
==========================================
+ Coverage 88.66% 89.52% +0.85%
==========================================
Files 15 15
Lines 794 821 +27
==========================================
+ Hits 704 735 +31
+ Misses 76 73 -3
+ Partials 14 13 -1
Continue to review full report in Codecov by Sentry.
|
Co-authored-by: Tomasz Janiszewski <janiszt@gmail.com>
|
Got a bit of a locking issue, when stats is enabled the shard tries to wlock but as it is now it’s already rlocked. This causes a deadlock issue, I’m thinking about moving the hit call outside getWithoutLock. |
|
seems like my test was failing because it was too big for the github action 🙂 looks ok now though. |
|
This is ready for another review 🙂 @janisz |
Closes #324
It works but it's not always faster, the sweet spot where the multi is faster seems to be using 512 shards. I tried using batches and getting all keys at once.