fix(asm): add checkpoint_txid to CheckpointTipUpdate log#1456
Open
fix(asm): add checkpoint_txid to CheckpointTipUpdate log#1456
Conversation
The v1 CheckpointTipUpdate log was missing the L1 transaction ID that carried the checkpoint transaction. The txid is needed on the consumer side to reference the originating L1 transaction.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #1456 +/- ##
==========================================
- Coverage 73.49% 64.30% -9.20%
==========================================
Files 779 777 -2
Lines 73386 73281 -105
==========================================
- Hits 53936 47121 -6815
- Misses 19450 26160 +6710
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 222 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Contributor
|
Commit: 7c7849a SP1 Execution Results
|
krsnapaudel
reviewed
Mar 4, 2026
| let l2_commitment = OLBlockCommitment::new(42, OLBlockId::from(Buf32::from([0xAB; 32]))); | ||
| let tip = CheckpointTip::new(7, 100, l2_commitment); | ||
| let update = CheckpointTipUpdate::new(tip); | ||
| let txid = Buf32::from([0xCD; 32]); |
Contributor
There was a problem hiding this comment.
I see tests use hardcoded values. I have tried my best to replace tests like these with proptest based tests. Can we do that?
delbonis
approved these changes
Mar 6, 2026
Comment on lines
+93
to
+104
|
|
||
| /// Txid of the L1 transaction that carried the checkpoint tx. | ||
| checkpoint_txid: Buf32, | ||
| } | ||
|
|
||
| impl CheckpointTipUpdate { | ||
| /// Creates a new [`CheckpointTipUpdate`] from a [`CheckpointTip`]. | ||
| pub fn new(tip: CheckpointTip) -> Self { | ||
| /// Creates a new [`CheckpointTipUpdate`] from a [`CheckpointTip`] and the | ||
| /// raw txid bytes of the L1 transaction that carried the checkpoint. | ||
| pub fn new(tip: CheckpointTip, checkpoint_txid: Buf32) -> Self { | ||
| Self { | ||
| tip: CodecSsz::new(tip), | ||
| checkpoint_txid, |
Contributor
There was a problem hiding this comment.
Should this be txid or wtxid?
irnb
added
the
DO NOT MERGE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
CheckpointTipUpdatelog was missing the L1 transaction ID thatcarried the checkpoint transaction. The
txidis needed on the consumer side to reference the originating L1 transaction and fetch checkpoint tx witness.Description
Type of Change
Notes to Reviewers
Is this PR addressing any specification, design doc or external reference document?
If yes, please add relevant links:
Checklist
Related Issues