Skip to content

feat: use trait extensions instead of newtype#1491

Draft
prajwolrg wants to merge 1 commit intomainfrom
STR-1786-btc-extension-traits
Draft

feat: use trait extensions instead of newtype#1491
prajwolrg wants to merge 1 commit intomainfrom
STR-1786-btc-extension-traits

Conversation

@prajwolrg
Copy link
Contributor

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Is this PR addressing any specification, design doc or external reference document?

  • Yes
  • No

If yes, please add relevant links:

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added (where necessary) tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.
  • I have disclosed my use of AI in the body of this PR.

Related Issues

@codecov
Copy link

codecov bot commented Mar 13, 2026

Codecov Report

❌ Patch coverage is 90.63830% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.91%. Comparing base (4f8f41c) to head (ce297f4).

Files with missing lines Patch % Lines
...ates/asm/txs/bridge-v1/src/deposit_request/info.rs 25.00% 6 Missing ⚠️
crates/btc-types/src/arbitrary_bitcoin.rs 77.27% 5 Missing ⚠️
crates/btc-types/src/borsh_bitcoin.rs 97.14% 4 Missing ⚠️
crates/consensus-logic/src/asm_worker_context.rs 0.00% 2 Missing ⚠️
crates/asm/logs/src/checkpoint.rs 75.00% 1 Missing ⚠️
crates/asm/subprotocols/bridge-v1/src/handler.rs 50.00% 1 Missing ⚠️
.../asm/subprotocols/checkpoint-v0/src/subprotocol.rs 0.00% 1 Missing ⚠️
crates/asm/worker/src/state.rs 0.00% 1 Missing ⚠️
crates/rpc/types/src/types.rs 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (4f8f41c) and HEAD (ce297f4). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (4f8f41c) HEAD (ce297f4)
unit 2 1
functional 1 0
@@            Coverage Diff             @@
##             main    #1491      +/-   ##
==========================================
- Coverage   74.33%   64.91%   -9.43%     
==========================================
  Files         783      783              
  Lines       73713    73605     -108     
==========================================
- Hits        54795    47779    -7016     
- Misses      18918    25826    +6908     
Flag Coverage Δ
functional ?
unit 64.91% <90.63%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
bin/alpen-cli/src/cmd/deposit.rs 64.68% <100.00%> (ø)
crates/asm/common/src/aux/collector.rs 100.00% <100.00%> (ø)
crates/asm/common/src/aux/data.rs 100.00% <100.00%> (ø)
...s/asm/subprotocols/bridge-v1/src/state/operator.rs 98.83% <100.00%> (-0.02%) ⬇️
...m/subprotocols/bridge-v1/src/validation/deposit.rs 97.45% <100.00%> (ø)
...asm/subprotocols/bridge-v1/src/validation/slash.rs 100.00% <100.00%> (ø)
...m/subprotocols/bridge-v1/src/validation/unstake.rs 100.00% <100.00%> (ø)
crates/asm/txs/bridge-v1/src/deposit/info.rs 91.89% <100.00%> (-0.97%) ⬇️
crates/asm/txs/bridge-v1/src/deposit/parse.rs 100.00% <100.00%> (ø)
...tes/asm/txs/bridge-v1/src/deposit_request/parse.rs 100.00% <100.00%> (ø)
... and 16 more

... and 223 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2026

Commit: 21204bc

SP1 Execution Results

program cycles success
EVM EE STF 1,322,061
Checkpoint 5,226
Checkpoint New 883,623

@prajwolrg prajwolrg force-pushed the STR-1786-btc-extension-traits branch from 7f4e361 to ce297f4 Compare March 13, 2026 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant