fix!(strata): use sequencer config for poll interval#1493
fix!(strata): use sequencer config for poll interval#1493
Conversation
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #1493 +/- ##
==========================================
- Coverage 74.33% 64.88% -9.45%
==========================================
Files 783 781 -2
Lines 73713 73635 -78
==========================================
- Hits 54795 47780 -7015
- Misses 18918 25855 +6937
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 219 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Commit: c1d1b67 SP1 Execution Results
|
86aa0ef to
1e02884
Compare
bewakes
left a comment
There was a problem hiding this comment.
Block time and duty poll intervals are actually two different things although in our case polling duties based on block time probably is fine because there's no other duty that needs to be polled faster than this.
|
Also this might conflict with what's being done in this PR, which keeps duty-poll-interval intact. |
@krsnapaudel how you wanna handle this? I do see that #1490 is more wide-scoped than this one... |
@storopoli @bewakes Duty polling is sequencer signer thing afaik. So this is also related to separation of sequencer signer. I would leave duty polling interval around until @purusang's PR (#1497) for separation. |
|
@storopoli You should also rebase so the old dbtool failures disappear. |
|
Closing this since we need the |
Description
The OL sequencer in
stratawas producing blocks every 1 second instead of respecting the configuredsequencer.ol_block_time_msin thesequencer.tomlconfig file. The--duty-poll-interval/-iCLI flag defaulted to1_000ms, and this poll interval drove theSequencerTimerInputtick rate. During chain startup/catchup, all block target timestamps are in the past, so every tick produced a block immediately -- making the poll interval the effective block time.This removes the
--duty-poll-interval/-iCLI flag and instead derives the sequencer service tick interval fromol_block_time_msin the sequencer runtime config (sequencer.toml).Type of Change
Notes to Reviewers
This is breaking since it removes the
--duty-poll-interval/-iCLI flag (Cc @voidash)Done with the help of Opus 4.6 thinking high
Had to increase timeouts in
test_epoch_progressionandtest_interaction_with_stratabecause now blocktime is respected and blocks are 5s and not 1s by default:alpen/functional-tests-new/common/config/config.py
Lines 80 to 84 in 1e02884
Is this PR addressing any specification, design doc or external reference document?
If yes, please add relevant links:
Checklist
Related Issues