STR 2586 update checkpoint status in OL checkpoint db#1514
STR 2586 update checkpoint status in OL checkpoint db#1514krsnapaudel wants to merge 4 commits intomainfrom
Conversation
|
Commit: 9c948fa SP1 Execution Results
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #1514 +/- ##
===========================================
- Coverage 76.29% 65.00% -11.30%
===========================================
Files 802 800 -2
Lines 76189 76595 +406
===========================================
- Hits 58130 49791 -8339
- Misses 18059 26804 +8745
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 241 files with indirect coverage changes 🚀 New features to boost your workflow:
|
bewakes
left a comment
There was a problem hiding this comment.
Looks good mostly. Some concerns over the splitted statuses which are sequential in nature.
delbonis
left a comment
There was a problem hiding this comment.
Needs rework, the database concepts were misconceived.
@delbonis Your suggestions have many side effects. As mentioned in the slack message.
|
Description
EpochCommitment, replacing the combined mutableOLCheckpointEntrymodel.Unsigned/Signed/Confirmed/Finalized) at read time from table presence and L1 depth, usingl1_reorg_safe_depthfor finalization instead of checkpoint-progression-baseddeclared_final_epoch.Type of Change
Notes to Reviewers
Is this PR addressing any specification, design doc or external reference document?
If yes, please add relevant links:
Checklist
Related Issues
STR-2586