STR 2431 Enforce MAX_LOGS_PER_BLOCK during OL STF and block assembly#1518
Open
krsnapaudel wants to merge 2 commits intomainfrom
Open
STR 2431 Enforce MAX_LOGS_PER_BLOCK during OL STF and block assembly#1518krsnapaudel wants to merge 2 commits intomainfrom
MAX_LOGS_PER_BLOCK during OL STF and block assembly#1518krsnapaudel wants to merge 2 commits intomainfrom
Conversation
delbonis
requested changes
Mar 20, 2026
Contributor
|
Commit: 247a641 SP1 Execution Results
|
Codecov Report✅ All modified and coverable lines are covered by tests.
@@ Coverage Diff @@
## main #1518 +/- ##
===========================================
- Coverage 76.52% 65.52% -11.00%
===========================================
Files 802 800 -2
Lines 76189 76348 +159
===========================================
- Hits 58302 50026 -8276
- Misses 17887 26322 +8435
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 240 files with indirect coverage changes 🚀 New features to boost your workflow:
|
1a299b8 to
2748f20
Compare
…terminal finalization
delbonis
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The SSZ-defined
MAX_LOGS_PER_BLOCK(4096) existed in chain-types but wasnever enforced at runtime. Log collection used unbounded
Vec<OLLog>in allpaths.
Changes
Primitives (
ol/chain-types,ol/stf)MAX_LOGS_PER_BLOCKfromstrata_ol_chain_types_newExecError::LogsOverflow { count, max }ExecOutputBuffer::log_count()andverify_logs_within_block_limit()STF assembly (
execute_block_inputs)constructing final output
STF verification (
verify_block,verify_epoch_with_diff)verify_epoch_preseal_with_diffexcluded (no log collection)Block assembly (
process_transactions,build_block_template)Invalidreported, remain in mempool)
BlockConstruction(TooManyLogsInBlock)if manifest processing pushes logs over cap
This PR was created with help from Codex and Claude Code.
Type of Change
Notes to Reviewers
Is this PR addressing any specification, design doc or external reference document?
If yes, please add relevant links:
Checklist
Related Issues
STR-2431