PP-14612 - download CSV functionality for transactions per service #4773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons. The code has been migrated to Typescript and improved. dates.ts is more stricter, safer (validation input, support data object, sensible defaults. get-query-string-for-params.ts defined improve readability, brand get converted from string t array before hand stops repeated keys. avoids treating pagination default 0 as missing transaction-download.controller.ts explicit interfaces and types.
…e when there are no results. if there are more than 5000 results, the user needs to filter the results to download the transactions, the Download CSV will be disabled
…e when there are no results. if there are more than 5000 results, the user needs to filter the results to download the transactions, the Download CSV will be disabled
# Conflicts: # src/controllers/simplified-account/services/transactions/index.ts
…lass without a test. There is some cross-test contamination with service.create-service.test.js "when creating a service should assign gateway account id of sandbox account to service if org type is central:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
PP-14612 - download CSV functionality for transactions per service
Implement/migrate download CSV functionality for transactions. The code has been migrated to Typescript and improved.
dates.ts is more stricter, safer (validation input, support data object, sensible defaults.
get-query-string-for-params.ts defined improve readability, brand get converted from string t array before hand stops repeated keys. avoids treating pagination default 0 as missing
transaction-download.controller.ts explicit interfaces and types.
How
Screenshots (views have been added/changed)
button
CSV file in excel
keyboard nav
