feat: add BT-120 VAT exemption reason (backport #247)#255
feat: add BT-120 VAT exemption reason (backport #247)#255mergify[bot] wants to merge 1 commit intoversion-15-hotfixfrom
Conversation
(cherry picked from commit cec83b5) # Conflicts: # eu_einvoice/locale/de.po # eu_einvoice/locale/main.pot
|
Cherry-pick of cec83b5 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Greptile SummaryThis backport of #247 adds a configurable BT-120 VAT exemption reason text field to E Invoice Settings and correctly wires it into both the export path (written only to zero-rated/exempt trade-tax lines) and the import path (read from
Confidence Score: 1/5Not safe to merge — unresolved git conflict markers in both locale files will break translation loading at runtime. Two P0 findings (unresolved merge conflicts in de.po and main.pot) pull the score to the floor. The Python and JSON changes themselves are correct and well-structured. eu_einvoice/locale/de.po and eu_einvoice/locale/main.pot must have their merge conflicts resolved. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[EInvoiceGenerator.create_einvoice] -->|reads once| B[frappe.db.get_single_value\nE Invoice Settings\nvat_exemption_reason_text]
B --> C[self.vat_exemption_reason_text]
C --> D[_add_item]
D -->|rate == 0| E[set exemption_reason_code]
E --> F[_set_optional_vat_exemption_reason_text\nli.settlement.trade_tax]
C --> G[_add_empty_tax]
G --> H[set exemption_reason_code]
H --> I[_set_optional_vat_exemption_reason_text\ntrade_tax]
F --> J[BT-120 in XML output]
I --> J
K[EInvoiceImport.parse_tax] -->|reads from XML| L[tax.exemption_reason._text]
L --> M[t.vat_exemption_reason_text\nin E Invoice Trade Tax child row]
Reviews (1): Last reviewed commit: "feat: add BT-120 VAT exemption reason (#..." | Re-trigger Greptile |
| @@ -183,6 +187,7 @@ msgstr "E-Rechnung konnte nicht validiert werden." | |||
| msgid "Charge Total" | |||
There was a problem hiding this comment.
Unresolved merge conflicts in locale file
de.po contains raw git conflict markers (<<<<<<< HEAD, =======, >>>>>>> cec83b5). A standard .po parser (e.g. Babel) treats these as illegal syntax and will fail to load the translation catalogue entirely, breaking all German UI strings in the module. The same issue is present in main.pot. Both files need a clean merge resolution before this branch can be shipped.
| msgstr "" | ||
|
|
||
| #: eu_einvoice/european_e_invoice/doctype/e_invoice_import/e_invoice_import.py:119 | ||
| #: eu_einvoice/european_e_invoice/doctype/e_invoice_import/e_invoice_import.py:120 | ||
| msgid "Please create or select a supplier before submitting" | ||
| msgstr "" | ||
|
|
||
| #: eu_einvoice/european_e_invoice/doctype/e_invoice_import/e_invoice_import.py:125 | ||
| #: eu_einvoice/european_e_invoice/doctype/e_invoice_import/e_invoice_import.py:126 |
Adds a BT-120 textfield for the VAT exemption reason to the E-Invoice Settings: #183
This is an automatic backport of pull request #247 done by Mergify.