ci: set up github actions#20
Merged
barredterra merged 6 commits intoversion-15from Dec 1, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR sets up a comprehensive GitHub Actions CI/CD pipeline for the working_time ERPNext app, including automated testing, linting, and release workflows. It also updates the pre-commit configuration to reflect the correct project name.
Key Changes:
- Adds three GitHub Actions workflows: server tests, linters, and semantic release automation
- Creates an installation helper script for setting up the Frappe/ERPNext test environment
- Updates pre-commit configuration from
banking.*toworking_time.*to match the actual project name
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
.pre-commit-config.yaml |
Updates file pattern from banking.* to working_time.* to match the correct project name |
.github/workflows/server-tests.yml |
Adds comprehensive test workflow with MariaDB service, Python/Node setup, caching, and test execution |
.github/workflows/release.yaml |
Implements semantic-release automation for version-15 branch |
.github/workflows/linters.yaml |
Adds pre-commit and semgrep linting checks for pull requests |
.github/helper/install.sh |
Creates bash script to set up Frappe bench environment and install dependencies for testing |
Comments suppressed due to low confidence (1)
.github/helper/install.sh:21
- The MySQL password is passed directly in the command line using
-proot(without a space). While this works, it's deprecated and generates warnings. Consider using theMYSQL_PWDenvironment variable instead for cleaner output:
export MYSQL_PWD=root
mysql --host 127.0.0.1 --port 3306 -u root -e "SET GLOBAL character_set_server = 'utf8mb4'"mysql --host 127.0.0.1 --port 3306 -u root -proot -e "SET GLOBAL character_set_server = 'utf8mb4'"
mysql --host 127.0.0.1 --port 3306 -u root -proot -e "SET GLOBAL collation_server = 'utf8mb4_unicode_ci'"
mysql --host 127.0.0.1 --port 3306 -u root -proot -e "CREATE USER 'test_frappe'@'localhost' IDENTIFIED BY 'test_frappe'"
mysql --host 127.0.0.1 --port 3306 -u root -proot -e "CREATE DATABASE test_frappe"
mysql --host 127.0.0.1 --port 3306 -u root -proot -e "GRANT ALL PRIVILEGES ON \`test_frappe\`.* TO 'test_frappe'@'localhost'"
mysql --host 127.0.0.1 --port 3306 -u root -proot -e "FLUSH PRIVILEGES"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Depends on Attendance doctype
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.