Skip to content

ci: set up github actions#20

Merged
barredterra merged 6 commits intoversion-15from
setup-ci
Dec 1, 2025
Merged

ci: set up github actions#20
barredterra merged 6 commits intoversion-15from
setup-ci

Conversation

@barredterra
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR sets up a comprehensive GitHub Actions CI/CD pipeline for the working_time ERPNext app, including automated testing, linting, and release workflows. It also updates the pre-commit configuration to reflect the correct project name.

Key Changes:

  • Adds three GitHub Actions workflows: server tests, linters, and semantic release automation
  • Creates an installation helper script for setting up the Frappe/ERPNext test environment
  • Updates pre-commit configuration from banking.* to working_time.* to match the actual project name

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
.pre-commit-config.yaml Updates file pattern from banking.* to working_time.* to match the correct project name
.github/workflows/server-tests.yml Adds comprehensive test workflow with MariaDB service, Python/Node setup, caching, and test execution
.github/workflows/release.yaml Implements semantic-release automation for version-15 branch
.github/workflows/linters.yaml Adds pre-commit and semgrep linting checks for pull requests
.github/helper/install.sh Creates bash script to set up Frappe bench environment and install dependencies for testing
Comments suppressed due to low confidence (1)

.github/helper/install.sh:21

  • The MySQL password is passed directly in the command line using -proot (without a space). While this works, it's deprecated and generates warnings. Consider using the MYSQL_PWD environment variable instead for cleaner output:
export MYSQL_PWD=root
mysql --host 127.0.0.1 --port 3306 -u root -e "SET GLOBAL character_set_server = 'utf8mb4'"
mysql --host 127.0.0.1 --port 3306 -u root -proot -e "SET GLOBAL character_set_server = 'utf8mb4'"
mysql --host 127.0.0.1 --port 3306 -u root -proot -e "SET GLOBAL collation_server = 'utf8mb4_unicode_ci'"

mysql --host 127.0.0.1 --port 3306 -u root -proot -e "CREATE USER 'test_frappe'@'localhost' IDENTIFIED BY 'test_frappe'"
mysql --host 127.0.0.1 --port 3306 -u root -proot -e "CREATE DATABASE test_frappe"
mysql --host 127.0.0.1 --port 3306 -u root -proot -e "GRANT ALL PRIVILEGES ON \`test_frappe\`.* TO 'test_frappe'@'localhost'"

mysql --host 127.0.0.1 --port 3306 -u root -proot -e "FLUSH PRIVILEGES"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/server-tests.yml Outdated
Comment thread .github/workflows/server-tests.yml Outdated
Comment thread .github/workflows/linters.yaml Outdated
Comment thread .github/workflows/release.yaml Outdated
Comment thread .github/workflows/release.yaml Outdated
Comment thread .github/workflows/server-tests.yml Outdated
Comment thread .github/helper/install.sh
barredterra and others added 4 commits December 1, 2025 23:36
Depends on Attendance doctype
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@barredterra barredterra merged commit 3fbcd46 into version-15 Dec 1, 2025
3 checks passed
@barredterra barredterra deleted the setup-ci branch December 1, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants