Error on removeSelection when no blocks exist#118
Open
jackbanditdude wants to merge 2 commits intoalyssaxuu:masterfrom
Open
Error on removeSelection when no blocks exist#118jackbanditdude wants to merge 2 commits intoalyssaxuu:masterfrom
jackbanditdude wants to merge 2 commits intoalyssaxuu:masterfrom
Conversation
Add a null check in removeSelection when parentNode evaluates to null
In firstBlock(), the blockSnap() function call ignores the return type, unlike other places we use blockSnap(). Adding in false check and removeSelection() call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a null check in removeSelection when parentNode evaluates to null