Handle nested JSON and JSON arrays in params properly

[a-alhusaini]

Before:

class SomeController
  def index
    params.validation { # ... }
    
    params["x"] # => string "[1,2,3]"
end

After

class SomeController
  def index
    params.validation { # ... }
    
    params["x"] # => Array(JSON::Any)
end

[HCLarsen]

JSON::Any::Type includes Array(JSON::Any), so is it redundant to include both, or is there something I'm missing?

[crimson-knight]

That was my thought as well, so I don't think we need the extra Array(JSON::Any)

[HCLarsen]

This is hard coded as a POST request. Does that mean that it can only be used with POST requests, or can it be used with PUT and PATCH requests too?

[crimson-knight]

Well this is just a test, but we should be testing POST PATCH AND PUT

[hugopl]

Maybe returning a JSON::PullParser would be better here, so people could use JSON::Serializable to decode these parameters. 🤔

[a-alhusaini]

When was that introduced in the language? I don't recall seeing this at the time I wrote this PR.

[crimson-knight]

@a-alhusaini it's been part of the std library for a few years

https://crystal-lang.org/api/1.10.1/JSON/PullParser.html