Needed support for more than 25 columns on import#313
Open
gbozo wants to merge 4 commits intoananthakumaran:masterfrom
Open
Needed support for more than 25 columns on import#313gbozo wants to merge 4 commits intoananthakumaran:masterfrom
gbozo wants to merge 4 commits intoananthakumaran:masterfrom
Conversation
…p to 255 rows of data(could be more). Not very pretty, but works for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tried to import a file with more than 25 columns.
Yours was hardcoded so when there were more than 25 columns your ASCII mapped it to Y,Z,[,\ which is unusable by your parser.
Changed it to support up to 255 columns for now. It maps the columns as ,Y,Z,AA,AB ...