Skip to content

Conversation

@clydin
Copy link
Member

@clydin clydin commented Jan 12, 2026

This change modernizes the findUp utility across the codebase. Replaced path.parse().root with path.dirname(dir) === dir check. Introduced an asynchronous version (findUp) in the CLI utility and renamed the synchronous version to findUpSync to align with Node.js conventions. Updated packages/angular/cli/src/utilities/config.ts to use the asynchronous findUp for non-blocking configuration discovery.

This change modernizes the `findUp` utility across the codebase. Replaced `path.parse().root` with `path.dirname(dir) === dir` check. Introduced an asynchronous version (`findUp`) in the CLI utility and renamed the synchronous version to `findUpSync` to align with Node.js conventions. Updated `packages/angular/cli/src/utilities/config.ts` to use the asynchronous `findUp` for non-blocking configuration discovery.
@clydin clydin marked this pull request as ready for review January 12, 2026 20:26
@clydin clydin added the target: minor This PR is targeted for the next minor release label Jan 12, 2026
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants