feat(bindings): add component data-binding contracts - #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #48.
Replaces the old node-local prop binding model with app-level component data-binding contracts.
Adds/reworks:
ComponentInstanceIdComponentTypeIdBindingOperationRefBindingValueSourceBindingValueExpressionBindingFallbackBindingLifecycleBehaviorPropBindingBindingInputValueBindingInputMapBindingConditionEventBindingTargetEventBindingComponentDataBindingComponentDataBindingRegistryAppManifest.dataSourcesAppManifest.dataBindingsRemoves from the public model:
NodePropBindingDbCollectionQueryBindingsource: 'db.collection'binding sourceUiNode.bindingsUiNode.eventstypes.tsScope intentionally excluded
@ankhorage/data-sourcesimplementationThose are follow-up repo-local tasks.
Verification
I could not run local validation from this session because the environment cannot reliably clone/resolve GitHub repositories.
Please run before merge:
bun install bun run build bun run lint:fix bun run testNotes
DB-backed reads are now represented through data-source operation references instead of the old direct
db.collectionbinding source. Runtime lifecycle/cache state remains outside the serializable binding contracts.