add paramater for max_instances for gcp_cloudfunctions_cloud_function …#290
Open
nolandseigler wants to merge 16 commits intoansible-collections:masterfrom
Conversation
Signed-off-by: Modular Magician <magic-modules@google.com>
…nsible-collections#273) * add source_image to google_compute_image * add source_snapshot to google_compute_image * PR comment changes Signed-off-by: Modular Magician <magic-modules@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
* Add new field filter to pubsub. Fixes: hashicorp/terraform-provider-google#6727 * Fixed filter name, it was improperly set. * add filter key to pubsub subscription unit test * spaces not tabs! * hardcode filter value in test * revert remove escaped quotes Co-authored-by: Tim O'Connell <hi@timoconnell.co.uk> Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Tim O'Connell <hi@timoconnell.co.uk>
Signed-off-by: Modular Magician <magic-modules@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
…llections#278) Add enableMessageOrdering to Pub/Sub Subscription Signed-off-by: Modular Magician <magic-modules@google.com>
* use {product}.googleapis.com endpoints
* use actual correct urls
* fix zone data source test
* fix network peering tests
* possibly fix deleting default network
Signed-off-by: Modular Magician <magic-modules@google.com>
…le-collections#280) * [provider-yaml] - Removed instances where input and output are both true * modified to only supply output. Following pattern from bigquerydatatransfer Co-authored-by: Scott Suarez <scottsuarez@google.com> Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Scott Suarez <scottsuarez@google.com>
* retrypolicy attribute added * test case updated Signed-off-by: Modular Magician <magic-modules@google.com>
…nsible-collections#282) Co-authored-by: Dana Hoffman <danahoffman@google.com> Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Dana Hoffman <danahoffman@google.com>
…tions#283) Co-authored-by: Cameron Thornton <camthornton@google.com> Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Cameron Thornton <camthornton@google.com>
…s#286) * added storage locations * add storage locations to field * tweak cmek logic * fix the decoder logic and cleanup whitespaces * remove duplicate entry Signed-off-by: Modular Magician <magic-modules@google.com>
…e-collections#287) Signed-off-by: Modular Magician <magic-modules@google.com>
…ol (#3973) (ansible-collections#289) Co-authored-by: Edward Sun <sunedward@google.com> Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Edward Sun <sunedward@google.com>
nolandseigler
changed the title
|
Hi friends, I'd love to see this feature, max instances parameter exposed to the Ansible Does anyone have any feedback that might help this move forward? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Module: gcp_cloudfunctions_cloud_function
SUMMARY
Add the ability to set the max_instances parameter when creating a cloud function.
ISSUE TYPE
COMPONENT NAME
gcp_cloudfunctions_cloud_function
ADDITIONAL INFORMATION
maxInstances: https://cloud.google.com/functions/docs/reference/rest/v1/projects.locations.functions#CloudFunction.FIELDS.max_instances:~:text=projects.-,maxInstances,See%20the%20Max%20Instances%20Guide%20for%20more%20details.