Add Service Account Impersonation + Secret Manager Filter#321
Add Service Account Impersonation + Secret Manager Filter#321upodroid wants to merge 12 commits intoansible-collections:masterfrom
Conversation
Signed-off-by: Modular Magician <magic-modules@google.com>
…nsible-collections#273) * add source_image to google_compute_image * add source_snapshot to google_compute_image * PR comment changes Signed-off-by: Modular Magician <magic-modules@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
* Add new field filter to pubsub. Fixes: hashicorp/terraform-provider-google#6727 * Fixed filter name, it was improperly set. * add filter key to pubsub subscription unit test * spaces not tabs! * hardcode filter value in test * revert remove escaped quotes Co-authored-by: Tim O'Connell <hi@timoconnell.co.uk> Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Tim O'Connell <hi@timoconnell.co.uk>
Signed-off-by: Modular Magician <magic-modules@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
…llections#278) Add enableMessageOrdering to Pub/Sub Subscription Signed-off-by: Modular Magician <magic-modules@google.com>
* use {product}.googleapis.com endpoints
* use actual correct urls
* fix zone data source test
* fix network peering tests
* possibly fix deleting default network
Signed-off-by: Modular Magician <magic-modules@google.com>
…le-collections#280) * [provider-yaml] - Removed instances where input and output are both true * modified to only supply output. Following pattern from bigquerydatatransfer Co-authored-by: Scott Suarez <scottsuarez@google.com> Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Scott Suarez <scottsuarez@google.com>
* retrypolicy attribute added * test case updated Signed-off-by: Modular Magician <magic-modules@google.com>
…e.cloud into impersonation
|
The |
toumorokoshi
left a comment
toumorokoshi
left a comment
There was a problem hiding this comment.
Thanks for the commit! I'm reviewing this a bit out-of-order since I hear it's valuable.
I left a couple comments, but I think there should be a test of this new feature (in the tests/integrations/targets directory, or perhaps a unit test) to get this merged in.
Obviously this commit is years old, so if someone wants to send an updated PR with the changes, I'm happy to take a look. Otherwise I'll process this as we have more tests and see if I can fix it up.
| @@ -0,0 +1,60 @@ | |||
| # (c) 2019, Eric Anderson <eric.sysmin@gmail.com> | |||
There was a problem hiding this comment.
I think this copyright is incorrect? seems like copy-pasted code from a separate file.
It should reflect the author of the code.
| } | ||
| if not params['scopes']: | ||
| params['scopes'] = ['https://www.googleapis.com/auth/cloudkms'] | ||
| params['scopes'] = ['https://www.googleapis.com/auth/cloud-platform'] |
There was a problem hiding this comment.
this is technically a backwards-incompatible change (the default value of a field changing).
Is there a specific reason this needs to be done in this change?
|
@aoktox thanks for the ping! Hopefully we get all these cleaned up, but calling out the important ones is helpful for now. I took a quick look but I'm worried we don't have enough testing to merge it in as-is. If you want to try updating it that would be great, otherwise it'll be in my queue along with the other 30 PRs, and likely an AI after I get all the tests passing in the CI. |
|
What's the deal with this one? This would be very useful for my team. SA impersonation is an widely used feature of GCP automation. Seems like ansible should be leveraging its use already. |
|
I've created a version of this with just the impersonation changes, plus documentation updates: #627 |
5 participants
SUMMARY
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
@rambleraptor ^