inventory plugin: adding the instance hostname field as inventory hostname#438
Open
DeLoWaN wants to merge 3 commits intoansible-collections:masterfrom
Open
inventory plugin: adding the instance hostname field as inventory hostname#438DeLoWaN wants to merge 3 commits intoansible-collections:masterfrom
DeLoWaN wants to merge 3 commits intoansible-collections:masterfrom
Conversation
|
Can we please get some eyes on the PR? I also need this feature. |
Author
|
So apparently there is a workaround implemented last month: #464 |
|
Thanks! I saw that, but i guess not ideal given the hostname field does exist. it's a small lift to add that label. Do you think it will be a hard no on this PR? |
Author
|
I don't know, it would be nice to have some input from the maintainers, as this PR is open for more than 4 months. |
|
Yes! I agree, I thought Ansible's strategy in forking content into community maintained collections was to avoid situations like this. |
thekad
added a commit
to thekad/google.cloud
that referenced
this pull request
Jun 9, 2025
Fixes ansible-collections#434 It is basically the same as ansible-collections#438 but with a few extra checks, don't want to rebase the whole thing. Signed-off-by: Jorge Gallegos <jgallego@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
inventory plugin: adding the instance hostname field as inventory hostname
I opened an issue but it's preferable to do this on a PR.
Fixes #434
I think it would be a great addition. In my setup I use the
hostnamefield of the instance which allows me to use a full FQDN. I cannot use as-is the FQDN in thenamefield since it does not allow dots ".".I am concerned about how to handle the fact that the
hostnamefield might be absent (it is not mandatory on GCP). I fallbacked on thenamefield.What do you think ?
ISSUE TYPE
COMPONENT NAME
inventory
ADDITIONAL INFORMATION