Skip to content

Enhance missing suboptions for disk_encryption_key and source_snapsho…#515

Open
ua6Iiji6 wants to merge 1 commit intoansible-collections:masterfrom
ua6Iiji6:master
Open

Enhance missing suboptions for disk_encryption_key and source_snapsho…#515
ua6Iiji6 wants to merge 1 commit intoansible-collections:masterfrom
ua6Iiji6:master

Conversation

@ua6Iiji6
Copy link
Copy Markdown

…t_encryption_key of module gcp_compute_region_disk.py

SUMMARY

Adding options for CMEK of regional disks

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

gcp_compute_region_disk

ADDITIONAL INFORMATION

…t_encryption_key of module gcp_compute_region_disk.py
Copy link
Copy Markdown
Collaborator

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good!

Can you add some testing around this feature? If there's a test I can run to verify (modifying the existing compute_region_disk test is fine), then I'm happy to merge.

https://github.com/ansible-collections/google.cloud/blob/master/CONTRIBUTING.md

@ua6Iiji6
Copy link
Copy Markdown
Author

Hi, i was checking the collection, there are no tests implemented for CMEK in the whole collection allthough its already in use. If there would be a blueprint i could transfer it to regional disk. But i'am not able to write these test from scratch for you. I'm very sorry.

@toumorokoshi
Copy link
Copy Markdown
Collaborator

Does the key need to be CMEK? There's tests for a KMS Crypto Key resource: https://github.com/ansible-collections/google.cloud/blob/master/tests/integration/targets/gcp_kms_crypto_key/tasks/autogen.yml.

Regardless if you don't have the bandwidth, it's not an issue. I'll this PR parked in case someone has time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants