feat: add secretmanager info module (#579)#580
feat: add secretmanager info module (#579)#580tze-dev wants to merge 5 commits intoansible-collections:masterfrom
Conversation
toumorokoshi
left a comment
There was a problem hiding this comment.
Wow! thanks for the contribution.
Overall this looks good. Do you have a testcase to run this through?
| short_description: Gather info for GCP Secret Manager - List secrets and versions metadata. | ||
| author: Tze L. (https://github.com/tl-aiyor) | ||
| requirements: | ||
| - python >= 2.6 |
There was a problem hiding this comment.
will this really work with python2.6? Since it's a new module, we could just up the version.
There was a problem hiding this comment.
What version do you suggest I bump up to? I can amend it if required.
There was a problem hiding this comment.
I guess ansible 2.14 supports 2.7 or newer as of 2.13: https://endoflife.date/ansible-core#python-compatibility.
So how about updating to 2.7 at least?
There was a problem hiding this comment.
Updated the req in documentation from 2.6 to 2.7 in #8b88a27
|
I think if you can fix the sanity/lint errors I'm happy to merge it. |
@toumorokoshi just want to check in to see the progress of this? Thx |
SUMMARY
PR for implementing #579
This is to implement an info module for retrieving list of GCP Secret Manager secrets metadata.
This module does NOT retrieve the actual secret payloads. Only metadata of secrets.
ISSUE TYPE
COMPONENT NAME
module:
gcp_secretmanager_infoADDITIONAL INFORMATION
Example usage: