Skip to content

fix(io): correct IO type name in AsyncIOParameter JSON constructor #1723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LHT129 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(io): correct IO type name in AsyncIOParameter JSON constructor #1723

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2f8aae
fix(io): correct IO type name in AsyncIOParameter JSON constructor
LHT129 Mar 20, 2026
3d389d0
fix(io): fix code formatting in AsyncIOParameter constructor
LHT129 Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/io/async_io_parameter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@ namespace vsag {
AsyncIOParameter::AsyncIOParameter() : IOParameter(IO_TYPE_VALUE_ASYNC_IO) {
}

AsyncIOParameter::AsyncIOParameter(const vsag::JsonType& json)
: IOParameter(IO_TYPE_VALUE_BUFFER_IO) {
AsyncIOParameter::AsyncIOParameter(const vsag::JsonType& json) : AsyncIOParameter() {
this->FromJson(json); // NOLINT(clang-analyzer-optin.cplusplus.VirtualCall)
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FromJson appears to be virtual (per the NOLINT), and calling virtual functions from constructors can cause surprising behavior if AsyncIOParameter is used as a base class (virtual dispatch won’t reach further-derived overrides during base construction). Consider making the class final, making FromJson non-virtual, or moving JSON parsing into a non-virtual helper/static factory that runs after full object construction.

Suggested change
this->FromJson(json); // NOLINT(clang-analyzer-optin.cplusplus.VirtualCall)
CHECK_ARGUMENT(json.Contains(IO_FILE_PATH_KEY), "miss file_path param in async io type");
this->path_ = json[IO_FILE_PATH_KEY].GetString();

Copilot uses AI. Check for mistakes.
}

Expand Down
Loading