v4.0: blockstore: Remove support for deprecated special columns (backport of #11455)#11468
Open
mergify[bot] wants to merge 1 commit intov4.0from
Open
v4.0: blockstore: Remove support for deprecated special columns (backport of #11455)#11468mergify[bot] wants to merge 1 commit intov4.0from
mergify[bot] wants to merge 1 commit intov4.0from
Conversation
Author
|
Cherry-pick of e43b0de has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
154493d to
e0c297b
Compare
The TransactionStatus, TransactionMemos, and AddressSignatures columns use to have a u64 in their key format. That u64 was used for the cleaning (compaction) mechanism and pertained to an entry in the TransactionStatusIndex column. When these columns were rekeyed to drop the u64, logic was added to find values with both the old and new key format in order to support the transition. But, the old format hasn't been written for years so it is reasonable to drop support for it now. This change removes the TransactionStatusIndex column and drops support for reading the old key formats in the transaction metadata columns. (cherry picked from commit e43b0de)
e0c297b to
e336e31
Compare
|
The cherry-pick wasn't clean due to a couple minor issues (v4.1 has extra AG columns, v4.1 shifted column ordering, etc), but fixup has the line counts matching exactly. I manually reviewed and diff looks to be identical. Force push after was to pickup tip of v4.0 to clear rustsec warnings |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## v4.0 #11468 +/- ##
=========================================
- Coverage 83.0% 83.0% -0.1%
=========================================
Files 838 838
Lines 317202 316643 -559
=========================================
- Hits 263578 263019 -559
Misses 53624 53624 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The TransactionStatus, TransactionMemos, and AddressSignatures columns use to have a u64 in their key format. That u64 was used for the cleaning (compaction) mechanism and pertained to an entry in the TransactionStatusIndex column.
When these columns were rekeyed to drop the u64, logic was added to find values with both the old and new key format in order to support the transition. But, the old format hasn't been written for years so it is reasonable to drop support for it now.
Summary of Changes
This change removes the TransactionStatusIndex column and drops support for reading the old key formats in the transaction metadata columns.
Reference PR's of interest:
clean_slot_0v4.0 Backport
I'd like to propose backporting this change to v4.0. While not critical (ie no key bugs fixed), we already have several breaking changes in v4.0 that will disallow v4.0 from reading old blockstores. It is nice to have all of those in one version IMO.
And while the line count is high, the PR is ~90% red lines
This is an automatic backport of pull request #11455 done by Mergify.