[Hopper] Support sink attention (learnable sink)#4
Open
aoxy wants to merge 20 commits into
Open
Conversation
9df7964 to
1b090a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for sink attention (learnable sink) in FlashAttention-3 (Hopper architecture), matching the functionality already available in FlashAttention-2.
Sink attention allows a learnable parameter per head to be added to the attention scores before the softmax operation. This provides a "sink" that can absorb attention probability, which has been shown to be useful for models like GPT-OSS.
Key Changes:
learnable_sinkin the Hopper forward and backward kernels.flash_attn_func,flash_attn_varlen_func, andflash_attn_with_kvcacheto accept thelearnable_sinktensor.learnable_sink, enabling end-to-end training of the sink parameters.mha_fwdandmha_bwdbindings inhopper/flash_api.cppto handle the newlearnable_sinkanddsinktensors.Testing:
hopper/test_flash_attn.py.hopper/test_util.pyto include sink attention logic.I have already added the tests to
tests/and confirmed they pass.