Facky tests revealed mainly with faster CI (aka Github Actions but also with Java 25) #1610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanouii
force-pushed
the
fix/flacky-tests-github-actions
branch
2 times, most recently
from
1d892cb to
541942e
Compare
…Info message on exception
…ailover During failover in transacted sessions with async dispatch (MessageListener), prefetched messages sitting in the unconsumedMessages buffer were not being tracked in previouslyDeliveredMessages. This caused them to be incorrectly identified as duplicates on redelivery and poison-acked to the DLQ.
…the priority ordering not the overall performance, so it's ok
Changes were meant to fix following bug, but it's not reliable. So better to revert it all together. AMQ-9829 Track prefetched messages for duplicate suppression during failover During failover in transacted sessions with async dispatch (MessageListener), prefetched messages sitting in the unconsumedMessages buffer were not being tracked in previouslyDeliveredMessages. This caused them to be incorrectly identified as duplicates on redelivery and poison-acked to the DLQ.
jeanouii
force-pushed
the
fix/flacky-tests-github-actions
branch
from
c2a5a80 to
a695119
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes various fixes related to race conditions or bugs