ARIES-2197 Add TLS/MTLS support to TCP Provider#60
Open
amichair wants to merge 7 commits intoapache:masterfrom
Open
ARIES-2197 Add TLS/MTLS support to TCP Provider#60amichair wants to merge 7 commits intoapache:masterfrom
amichair wants to merge 7 commits intoapache:masterfrom
Conversation
added 7 commits
July 2, 2025 10:15
…Service so that resources can be properly released
…ol (~100x throughput)
…l with slight refactoring
alien11689
reviewed
Apr 7, 2026
| static final int DEFAULT_NUM_THREADS = 10; | ||
|
|
||
| private final Map<String, Object> props; | ||
| private final String uuid = UUID.randomUUID().toString(); // fallback id |
Contributor
There was a problem hiding this comment.
instead of uuid we can call the fieldfallbackId
| RemoteConstants.REMOTE_CONFIGS_SUPPORTED + "=" + TcpProvider.TCP_CONFIG_TYPE // | ||
| }) | ||
| }, | ||
| configurationPid="org.apache.aries.rsa.provider.tcp") |
Contributor
There was a problem hiding this comment.
should we make a const for this property also?
| } | ||
| } catch (NoSuchAlgorithmException | KeyManagementException | UnrecoverableKeyException | IOException | | ||
| KeyStoreException | CertificateException e) { | ||
| throw new RuntimeException("Error initializing SSL Context", e); |
Contributor
There was a problem hiding this comment.
can we throw some better exception? I mean our exception
| private Endpoint ep; | ||
| private ImportedService importedService; | ||
|
|
||
| public void test(Map<String, Object> providerProps) throws IOException { |
Contributor
There was a problem hiding this comment.
should it be private? I thought first that we are using some old test framework, not Junit 4
| Map<String, Object> props = new HashMap<>(); | ||
| EndpointHelper.addObjectClass(props, exportedInterfaces); | ||
| int port = getFreePort(); | ||
| props.put("aries.rsa.hostname", "localhost"); |
Contributor
There was a problem hiding this comment.
can we use the defined consts?
| public class TcpProviderTLSTest { | ||
|
|
||
| private static String | ||
| KEYSTORE = TcpProviderTest.class.getResource("/keystore.p12").getPath(), |
Contributor
There was a problem hiding this comment.
you can provide here the commands you used to create the files - just in case we want to add more
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented TLS+MTLS+tests.
This PR sits on top of the ARIES-2121 PR, so that PR needs to be merged first.