Skip to content

Conversation

@HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Jan 8, 2026

Rationale for this change

Workflows cpp_extra.yml, r_extra.yml and package_linux.yml call reusable workflows (check_labels.yml and report_ci.yml) that require specific permissions. When #48771 added explicit permissions to these reusable workflows, the calling workflows were not updated to give those permissions.

This caused startup_failure errors when these workflows were triggered on pull requests. Here are example failures: https://github.com/apache/arrow/actions/runs/20809257825 and https://github.com/apache/arrow/actions/runs/20803198596

What changes are included in this PR?

Added missing permissions to the workflows

Are these changes tested?

Yes, I tested them within this PR.

Are there any user-facing changes?

No, dev-only.

@github-actions
Copy link

github-actions bot commented Jan 8, 2026

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@github-actions github-actions bot added the awaiting review Awaiting review label Jan 8, 2026
@HyukjinKwon HyukjinKwon marked this pull request as draft January 8, 2026 06:52
@HyukjinKwon HyukjinKwon force-pushed the minor-testing branch 2 times, most recently from 2546352 to 4116201 Compare January 8, 2026 06:56
@HyukjinKwon HyukjinKwon force-pushed the minor-testing branch 2 times, most recently from 0fc7fb5 to 602d2d5 Compare January 8, 2026 07:21
HyukjinKwon added a commit to HyukjinKwon/arrow that referenced this pull request Jan 8, 2026
HyukjinKwon added a commit to HyukjinKwon/arrow that referenced this pull request Jan 8, 2026
HyukjinKwon added a commit to HyukjinKwon/arrow that referenced this pull request Jan 8, 2026
@HyukjinKwon HyukjinKwon force-pushed the minor-testing branch 2 times, most recently from 5912e00 to d301933 Compare January 8, 2026 07:44
@HyukjinKwon HyukjinKwon changed the title [DO-NOT-MERGE] Testing path filter GH-48770: [CI] Following up to add missing permissions for reusable workflow calls Jan 8, 2026
@HyukjinKwon HyukjinKwon marked this pull request as ready for review January 8, 2026 07:48
@HyukjinKwon
Copy link
Member Author

This was my bad, @kou. I had to check here https://github.com/apache/arrow/actions/workflows/cpp_extra.yml. This should fix the issues.

@kou
Copy link
Member

kou commented Jan 8, 2026

Could you open a separated issue?
Some our tools such as release scripts assume one issue per pull request.

@HyukjinKwon
Copy link
Member Author

Sure I will do

@HyukjinKwon HyukjinKwon changed the title GH-48770: [CI] Following up to add missing permissions for reusable workflow calls GH-48780: [CI] Add missing permissions for reusable workflow calls Jan 8, 2026
@github-actions
Copy link

github-actions bot commented Jan 8, 2026

⚠️ GitHub issue #48780 has been automatically assigned in GitHub to PR creator.

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I've just merged a new PR adding a new workflow that uses the reusable workflows for the R Extra jobs, do you want to rebase and add those permissions there too?
https://github.com/apache/arrow/blob/076052300b8cc76d40ab20e04d23a913e7657473/.github/workflows/r_extra.yml

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Jan 8, 2026
@HyukjinKwon
Copy link
Member Author

Let me check!!

HyukjinKwon added a commit to HyukjinKwon/arrow that referenced this pull request Jan 8, 2026
@HyukjinKwon
Copy link
Member Author

HyukjinKwon commented Jan 8, 2026

tested in https://github.com/apache/arrow/actions/runs/20810917853 and made the changes accordingly!

and also updated PR description

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HyukjinKwon

@raulcd raulcd merged commit fe5e0e5 into apache:main Jan 8, 2026
47 of 49 checks passed
@raulcd raulcd removed the awaiting merge Awaiting merge label Jan 8, 2026
@github-actions github-actions bot added the awaiting merge Awaiting merge label Jan 8, 2026
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit fe5e0e5.

There weren't enough matching historic benchmark results to make a call on whether there were regressions.

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting merge Awaiting merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants