MINOR: [Python] Remove impossible TODO in server middleware#48794
Merged
lidavidm merged 1 commit intoapache:mainfrom Jan 9, 2026
Merged
MINOR: [Python] Remove impossible TODO in server middleware#48794lidavidm merged 1 commit intoapache:mainfrom
lidavidm merged 1 commit intoapache:mainfrom
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
Member
|
CI failure is #48795. |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 81e4046. There weren't enough matching historic benchmark results to make a call on whether there were regressions. The full Conbench report has more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Remove a TODO comment that has been impossible to implement. The TODO asked to "prevent duplicate keys" in
_ServerMiddlewareFactoryWrapper.start_call(), but this is already guaranteed by Python dict semantics. The TODO was added in commit d1848c8.What changes are included in this PR?
Remove the TODO comment from
python/pyarrow/_flight.pyx. Thefactoriesattribute has always been typed asdict(both in Cythoncdefand the__init__type hint), which inherently prevents duplicate keys.Are these changes tested?
I did not test.
Are there any user-facing changes?
No.