GH-33241: [Archery] Replace github3 with pygithub#48886
Open
fangchenli wants to merge 5 commits intoapache:mainfrom
Open
GH-33241: [Archery] Replace github3 with pygithub#48886fangchenli wants to merge 5 commits intoapache:mainfrom
fangchenli wants to merge 5 commits intoapache:mainfrom
Conversation
|
|
|
|
fangchenli
requested review from
assignUser,
jonkeane,
kou and
raulcd
as code owners
raulcd
reviewed
Jan 20, 2026
Member
raulcd
left a comment
raulcd
left a comment
There was a problem hiding this comment.
Thanks for the PR, awesome work. The changes look great in general. I'll have to take some time to do some validation as crossbow isn't extensively tested at the moment. Can you remove this one while I find some time to test it?
arrow/ci/conda_env_archery.txt
Line 22 in 894d6a3
Member
|
Failures are unrelated, will be fixed once the following issue closed. It has a PR ready to be merged: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Archery currently uses both pygithub and github3. It's unnecessary and increases maintenance burden.
What changes are included in this PR?
Replace all github3 usage with pygithub.
Are these changes tested?
Yes, unittests added.
Are there any user-facing changes?
No.
This PR includes breaking changes to public APIs. (If there are any breaking changes to public APIs, please explain which changes are breaking. If not, you can remove this.)
No.
This PR contains a "Critical Fix". (If the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld), please provide explanation. If not, you can remove this.)
No.