GH-46901: [C++][Compute] Add remainder and mod kernels#48914
Open
fangchenli wants to merge 3 commits intoapache:mainfrom
Open
GH-46901: [C++][Compute] Add remainder and mod kernels#48914fangchenli wants to merge 3 commits intoapache:mainfrom
fangchenli wants to merge 3 commits intoapache:mainfrom
Conversation
github-actions
bot
added
Component: C++
Component: Documentation
awaiting review
fangchenli
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Arrow is currently missing remainder and modulo kernels.
What changes are included in this PR?
Add kernels
remainder,remainder_checked,mod, andmod_checkedAre these changes tested?
Yes.
Are there any user-facing changes?
This PR includes breaking changes to public APIs. (If there are any breaking changes to public APIs, please explain which changes are breaking. If not, you can remove this.)