[ErrorProne] Fix UnusedVariable warnings across codebase#37770
Merged
damccorm merged 1 commit intoapache:masterfrom Mar 20, 2026
Merged
[ErrorProne] Fix UnusedVariable warnings across codebase#37770damccorm merged 1 commit intoapache:masterfrom
damccorm merged 1 commit intoapache:masterfrom
Conversation
github-actions
bot
added
java
build
io
extensions
runners
sql
dataflow
direct
elasticsearch
gcp
hbase
jdbc
kafka
kudu
core
flink
samza
spanner
labels
Contributor
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the code quality by activating the 'UnusedVariable' ErrorProne check. The changes primarily involve systematically addressing the warnings generated by this check, either by explicitly marking intentionally unused parameters and fields with Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Contributor
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Contributor
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enables the UnusedVariable ErrorProne check and addresses the resulting warnings. Most changes correctly suppress warnings for unused parameters or remove genuinely unused code. However, I found one instance where suppressing an unused parameter warning might be hiding a bug in a test, where a hardcoded value is used instead of the provided parameter. I've left a comment with a suggestion for a fix.
sdks/java/io/jdbc/src/test/java/org/apache/beam/sdk/io/jdbc/JdbcIOIT.java
Show resolved
Hide resolved
Contributor
|
Assigning reviewers: R: @ahmedabu98 for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #37770 +/- ##
============================================
- Coverage 56.86% 54.75% -2.11%
+ Complexity 3409 1690 -1719
============================================
Files 1178 1063 -115
Lines 187456 166898 -20558
Branches 3580 1226 -2354
============================================
- Hits 106593 91382 -15211
+ Misses 77478 73319 -4159
+ Partials 3385 2197 -1188
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Run Java_GCP_IO_Direct PreCommit |
supress warnings in tests
stankiewicz
force-pushed
the
error_prone_UnusedVariable
branch
from
ee5f190 to
8bdb2fa
Compare
Contributor
Author
|
Run Java PreCommit |
Contributor
Author
|
Run Java_PVR_Prism_Loopback PreCommit |
Contributor
Author
|
Run Java_Amazon-Web-Services2_IO_Direct PreCommit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables the
UnusedVariableerror-prone check and addresses the resulting warnings. Most fixes involved adding@SuppressWarnings("unused")to unused variables such as parameters passed to overriding methods where they are not read, or correctly ignoring variables that aren't intended to be read.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.