Skip to content

Fix flakiness in tests by increasing timeout and changing windowing type#37887

Merged
damccorm merged 1 commit intoapache:masterfrom
stankiewicz:fix_flaky_spanner_tests
Mar 20, 2026
Merged

Fix flakiness in tests by increasing timeout and changing windowing type#37887
damccorm merged 1 commit intoapache:masterfrom
stankiewicz:fix_flaky_spanner_tests

Conversation

@stankiewicz
Copy link
Contributor

@stankiewicz stankiewicz commented Mar 18, 2026

SpannerChangeStreamOrderedWithinKeyGloballyIT - test was flaky as it was assuming 4 distinct Spanner database writes can always happen within 2-second duration. if some write happened later as part of data preparation, dataflow was firing timer too early during the test.
SpannerChangeStreamOrderedWithinKeyIT - When FixedWindow is used, CI may not be lucky and commit one transaction at 23:59:59 and another at 00:00:01 which will end up in 2 different windows after GBK.
Moving to session window with gap to ensure that gbk will materialize complete data.

Fixes #37777


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to enhance the reliability of Spanner change stream integration tests by mitigating flakiness. It achieves this by adjusting test parameters to be more robust against timing variations and by refining the windowing strategy in one of the tests to correctly handle data that might span across traditional fixed window boundaries.

Highlights

  • Test Flakiness Resolution: Addressed flakiness in the SpannerChangeStreamOrderedWithinKeyGloballyIT test by increasing the timeIncrementInSeconds timeout from 2 to 10 seconds, providing more buffer for Spanner writes and preventing premature timer firing.
  • Windowing Strategy Update: Resolved flakiness in the SpannerChangeStreamOrderedWithinKeyIT test by switching from FixedWindows to Sessions.withGapDuration for windowing, ensuring complete data materialization even when transactions span across traditional fixed window boundaries.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@stankiewicz
Copy link
Contributor Author

assign set of reviewers

@github-actions
Copy link
Contributor

Assigning reviewers:

R: @ahmedabu98 for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@stankiewicz stankiewicz force-pushed the fix_flaky_spanner_tests branch from d143456 to 00bf791 Compare March 20, 2026 14:04
@stankiewicz
Copy link
Contributor Author

Run Java_GCP_IO_Direct PreCommit

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@damccorm damccorm merged commit 7b06555 into apache:master Mar 20, 2026
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Failing Test]: org.apache.beam.sdk.io.gcp.spanner.changestreams.it.SpannerChangeStreamOrderedWithinKeyIT testOrderedWithinKey

2 participants