Fix flakiness in tests by increasing timeout and changing windowing type#37887
Fix flakiness in tests by increasing timeout and changing windowing type#37887damccorm merged 1 commit intoapache:masterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to enhance the reliability of Spanner change stream integration tests by mitigating flakiness. It achieves this by adjusting test parameters to be more robust against timing variations and by refining the windowing strategy in one of the tests to correctly handle data that might span across traditional fixed window boundaries. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
assign set of reviewers |
|
Assigning reviewers: R: @ahmedabu98 for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
d143456 to
00bf791
Compare
|
Run Java_GCP_IO_Direct PreCommit |
SpannerChangeStreamOrderedWithinKeyGloballyIT - test was flaky as it was assuming 4 distinct Spanner database writes can always happen within 2-second duration. if some write happened later as part of data preparation, dataflow was firing timer too early during the test.
SpannerChangeStreamOrderedWithinKeyIT - When FixedWindow is used, CI may not be lucky and commit one transaction at 23:59:59 and another at 00:00:01 which will end up in 2 different windows after GBK.
Moving to session window with gap to ensure that gbk will materialize complete data.
Fixes #37777
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.