Skip to content

[ErrorProne] remove voidUsed check #37902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stankiewicz wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −4
Open

[ErrorProne] remove voidUsed check #37902

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1581,8 +1581,6 @@ class BeamModulePlugin implements Plugin<Project> {
"StringCaseLocaleUsage",
// DoFn methods are executed reflectively at pipeline runtime
"UnusedMethod",
// Void is a valid element type of DoFn elements
"VoidUsed",
]
disabledChecks.each {
options.errorprone.errorproneArgs.add("-Xep:${it}:OFF")
Expand Down
3 changes: 1 addition & 2 deletions .../java/org/apache/beam/runners/flink/translation/wrappers/streaming/FlinkKeyUtilsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,9 @@ public void testEncodeDecode() {

@Test
public void testNullKey() {
Void key = null;
VoidCoder coder = VoidCoder.of();

ByteBuffer byteBuffer = FlinkKeyUtils.encodeKey(key, coder);
ByteBuffer byteBuffer = FlinkKeyUtils.encodeKey(null, coder);
assertThat(FlinkKeyUtils.decodeKey(byteBuffer, coder), is(nullValue()));
}

Expand Down
Loading