fix: DATA_URL is improperly prefixed

[hazems]

Platforms affected

All (Android, iOS, OS X, Windows and Browser)

Motivation and Context

When calling navigator.camera.getPicture with destinationType set to Camera.DestinationType.DATA_URL, the success function is called with the base64 encoded data while it should has suitable data URL format on the following form:
data:[<mediatype>][;base64],<data>

It is an old issue in the library and it was previously reported under:
https://issues.apache.org/jira/browse/CB-9819

And recently, it was also reported by one of the library users:
#420

Description

I have implemented and tested the DATA_URL fix across all of the Camera plugin supported platforms:

1. Android (Java)
2. iOS (Objective C)
3. OS X (Objective C)
4. Browser (JavaScript)
5. Windows Platform (JavaScript)

Testing

I manually tested this change across all of these platforms and they work fine.

Checklist

• I've run the tests to see all new and existing tests pass
• Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))

[timbru31]

Just the snake_case style in Android, otherwise LGTM

[hazems]

Just the snake_case style in Android, otherwise LGTM

I will create a new PR to remove all old snake_case in the Android implementation to be compliant with Java Standards.

[janpio]

file removed?

[timbru31]

I was wondering the same. CI is green though.

[janpio]

Appium tests are currently removed from the project, as paramedic can't properly run them. PR #469 adds them back when the problems are fixed. But I am confused why this PR removes that file - because it should already be removed.

[hazems]

This is actually weird because this file was removed from master as a certain point in time. I will re-sync with master again and resolve any merge conflicts.

[hazems]

Checking it out, I think appium-tests/helpers/cameraHelper.js is removed in this commit:
19d8e2f

[hazems]

My PR had some updates to this cameraHelper.js file in order to assert that DATA_URL is properly prefixed, so not having these unit tests can cause issues while trying to fix #469 (Because the old unit tests were asserting the wrong DATA_URLs :)). So here is my proposed plan:

1. Postponing my PR fix: DATA_URL is improperly prefixed #432 until fix: add back Appium tests #469 is resolved.
2. Once PR fix: add back Appium tests #469 is resolved, I will sync-up and add the relevant unit tests for the DATA_URL feature.
3. Once finished, PR fix: DATA_URL is improperly prefixed #432 will be re-pushed.
   Does this sound a good plan?

[breautek]

Superceded by:

• fix(browser): Make data uri be returned as actual URI strings #912
• fix(android): Return data uris as an URI #910
• fix(ios): Sync camera API return to match Android changes #911