chore: Respect to legacySizeOfNull option for size function #3036
+52
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 768b3e9.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3036 +/- ##
============================================
+ Coverage 56.12% 59.54% +3.41%
- Complexity 976 1381 +405
============================================
Files 119 167 +48
Lines 11743 15537 +3794
Branches 2251 2576 +325
============================================
+ Hits 6591 9251 +2660
- Misses 4012 4989 +977
- Partials 1140 1297 +157 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
comphead
reviewed
Jan 7, 2026
|
|
||
| test("size - respect to legacySizeOfNull") { | ||
| val table = "t1" | ||
| withSQLConf(CometConf.COMET_NATIVE_SCAN_IMPL.key -> CometConf.SCAN_NATIVE_ICEBERG_COMPAT) { |
Contributor
There was a problem hiding this comment.
we need to make sure the ansi mode is off here. According to Spark
This function returns -1 for null input only if spark.sql.ansi.enabled is false and spark.sql.legacy.sizeOfNull is true. Otherwise, it returns null for null input. With the default settings, the function returns null for null input.
Contributor
Author
There was a problem hiding this comment.
Thanks @comphead. ANSI mode is disabled by default, but for safety, I've explicitly added the setting.
comphead
reviewed
Jan 7, 2026
| for { | ||
| isNotNullExprProto <- createIsNotNullExprProto(expr, inputs, binding) | ||
| sizeScalarExprProto <- scalarFunctionExprToProto("size", arrayExprProto) | ||
| emptyLiteralExprProto <- createLiteralExprProto(expr.legacySizeOfNull) |
Contributor
There was a problem hiding this comment.
should we also refer to ansi mode?
Contributor
Author
There was a problem hiding this comment.
For more safety, I used SQLConf.get.legacySizeOfNull.
Contributor
|
Thanks the PR makes sense to me, waiting for the CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
What changes are included in this PR?
How are these changes tested?
Test added as part of this PR.