[Feature] Add ST_CoordDim and ST_Dimension geo functions#61442
[Feature] Add ST_CoordDim and ST_Dimension geo functions#61442batuhanYagmurr wants to merge 7 commits intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
@batuhanYagmurr Thanks for adding these functions! I'm not a Doris developer, but out of curiosity had a look at your code. I noticed the tests are still missing, so you might want to add those... See this PR for some examples of how they can be added... |
1dfcff5 to
276e58d
Compare
2195709 to
433f20b
Compare
|
@zclllyybb in the original issue (#48203) you mention that PR's for new functions should automatically request your review, though I didn't see that happen with this PR... so do you think you could review this one? |
|
run buildall |
|
@feiniaofeiafei I see some tests are failing, but the results cannot be viewed, at least not by me... so not sure if @batuhanYagmurr can see them too, to fix the issues (if they arose due to the code in this PR)... can you share with @batuhanYagmurr what the errors are that need to be worked on? |
|
@batuhanYagmurr the compilation failed because of fe checkstyle |
Fix import ordering and indentation to comply with Doris checkstyle rules.
3f37907 to
ab84918
Compare
|
@zclllyybb Fixed the FE checkstyle errors. Could you please review again? |
3abb8bd to
a517378
Compare
There was a problem hiding this comment.
Tests have been added to test_gis_function.groovy for both ST_CoordDim and ST_Dimension functions.
@zclllyybb review please.
|
run buildall |
|
@batuhanYagmurr The pipeline ran again, now I see some errors in the backend tests... I also see you can access the TeamCity server now (through the guest login), so you should be able to have a look at the build log yourself... @feiniaofeiafei thx for running the builds... I see in my browser the connection to TeamCity lacks a TLS certificate, perhaps something to fix using something like Let's Encrypt or if it runs on kubernetes cert manager...? |
Add two new geo scalar functions:
FE: Added expression classes, registered in BuiltinScalarFunctions, added visitor methods in ScalarFunctionVisitor.
BE: Added struct implementations and registered in functions_geo.cpp.
What problem does this PR solve?
Issue Number: close #48203
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)