[fix](job) fix StreamingInsertJob incorrectly counting canceled tasks by JNSimba · Pull Request #61894 · apache/doris

JNSimba · 2026-03-30T09:56:24Z

What problem does this PR solve?

Problem Summary:

StreamingInsertJob does not support manual task cancellation
cancelAllTasks() is only triggered internally when job is STOPPED or PAUSED, meaning the task was interrupted passively
Change canceledTaskCount.incrementAndGet() in cancelAllTasks(), when task is running canceledTaskCount need incr

Test plan

Verify that when a streaming job is STOPPED/PAUSED, the failed task count increments correctly
Verify that canceled task count remains 0 for streaming jobs

StreamingInsertJob does not support manual task cancellation. The cancelAllTasks() is only triggered internally when the job is STOPPED or PAUSED, which semantically means the task was interrupted, not user-canceled. Change to increment failedTaskCount instead so that canceledTaskCount always stays 0 for streaming jobs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Thearas · 2026-03-30T09:56:30Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

JNSimba · 2026-03-30T09:58:00Z

run buildall

doris-robot · 2026-03-30T10:19:32Z

TPC-H: Total hot run time: 26714 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f1ac626d50d6dcc11b9deed14ecc2a23dbcb7a37, data reload: false

------ Round 1 ----------------------------------
orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	17609	4540	4292	4292
q2	q3	10648	773	528	528
q4	4679	356	252	252
q5	7564	1211	1015	1015
q6	181	179	151	151
q7	801	875	671	671
q8	9305	1482	1386	1386
q9	4820	4732	4691	4691
q10	6240	1906	1680	1680
q11	450	256	261	256
q12	691	599	475	475
q13	18040	2692	1947	1947
q14	234	237	215	215
q15	q16	724	724	663	663
q17	716	850	463	463
q18	5986	5356	5311	5311
q19	1107	981	626	626
q20	543	492	376	376
q21	4415	1821	1455	1455
q22	347	296	261	261
Total cold run time: 95100 ms
Total hot run time: 26714 ms

----- Round 2, with runtime_filter_mode=off -----
orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	4928	4665	4579	4579
q2	q3	3868	4380	3850	3850
q4	913	1204	781	781
q5	4075	4402	4354	4354
q6	196	185	145	145
q7	1752	1661	1511	1511
q8	2524	2716	2525	2525
q9	7663	7525	7685	7525
q10	3740	4006	3576	3576
q11	508	427	404	404
q12	475	593	455	455
q13	2494	2879	2092	2092
q14	284	297	269	269
q15	q16	708	771	704	704
q17	1193	1380	1363	1363
q18	7168	6851	6571	6571
q19	895	979	931	931
q20	2068	2167	2009	2009
q21	3966	3513	3527	3513
q22	468	417	375	375
Total cold run time: 49886 ms
Total hot run time: 47532 ms

doris-robot · 2026-03-30T10:30:20Z

TPC-DS: Total hot run time: 169102 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f1ac626d50d6dcc11b9deed14ecc2a23dbcb7a37, data reload: false

query5	4333	657	494	494
query6	345	227	203	203
query7	4210	460	260	260
query8	336	242	234	234
query9	8738	2739	2734	2734
query10	515	406	343	343
query11	6976	5106	4910	4910
query12	180	134	125	125
query13	1278	483	359	359
query14	5614	3754	3500	3500
query14_1	2838	2891	2821	2821
query15	210	204	176	176
query16	1034	498	467	467
query17	1121	727	629	629
query18	2534	456	361	361
query19	218	215	192	192
query20	138	128	125	125
query21	217	140	111	111
query22	13365	14072	14805	14072
query23	16764	16033	16189	16033
query23_1	15966	15681	15610	15610
query24	7175	1643	1214	1214
query24_1	1241	1278	1219	1219
query25	550	475	407	407
query26	1240	269	161	161
query27	2757	492	292	292
query28	4435	1870	1834	1834
query29	843	563	482	482
query30	304	227	190	190
query31	1024	932	888	888
query32	79	75	72	72
query33	524	339	296	296
query34	906	876	508	508
query35	643	686	588	588
query36	1084	1132	962	962
query37	135	97	87	87
query38	2998	2921	2899	2899
query39	850	849	816	816
query39_1	783	800	794	794
query40	241	150	135	135
query41	63	61	99	61
query42	261	258	255	255
query43	248	253	221	221
query44	
query45	196	187	182	182
query46	875	982	606	606
query47	2831	2129	2039	2039
query48	308	327	252	252
query49	633	464	384	384
query50	700	274	224	224
query51	4046	4082	4053	4053
query52	261	265	257	257
query53	289	334	282	282
query54	305	279	266	266
query55	89	84	86	84
query56	328	321	311	311
query57	1951	1905	1622	1622
query58	289	275	269	269
query59	2830	2954	2748	2748
query60	358	351	330	330
query61	156	156	163	156
query62	633	589	537	537
query63	302	276	271	271
query64	5116	1315	1060	1060
query65	
query66	1440	463	377	377
query67	24277	24351	24221	24221
query68	
query69	427	326	293	293
query70	976	981	948	948
query71	338	327	300	300
query72	2937	2742	2485	2485
query73	541	550	328	328
query74	9610	9571	9355	9355
query75	2871	2778	2475	2475
query76	2313	1029	662	662
query77	367	377	317	317
query78	10921	11135	10475	10475
query79	1126	767	584	584
query80	1379	629	529	529
query81	550	265	227	227
query82	1269	156	119	119
query83	334	266	247	247
query84	253	112	100	100
query85	937	501	452	452
query86	417	331	325	325
query87	3205	3116	3011	3011
query88	3591	2688	2676	2676
query89	429	369	346	346
query90	2043	195	179	179
query91	175	166	137	137
query92	84	73	72	72
query93	926	853	517	517
query94	664	346	296	296
query95	602	403	318	318
query96	644	520	236	236
query97	2497	2480	2405	2405
query98	232	222	218	218
query99	1010	1015	978	978
Total cold run time: 250651 ms
Total hot run time: 169102 ms

JNSimba · 2026-03-31T09:44:52Z

run nonConcurrent

sollhui

LGTM

github-actions · 2026-03-31T11:07:13Z

PR approved by anyone and no changes requested.

liaoxin01

LGTM

github-actions · 2026-03-31T11:59:39Z

PR approved by at least one committer and no changes requested.

JNSimba · 2026-03-31T12:39:52Z

run buildall

doris-robot · 2026-03-31T13:00:29Z

TPC-H: Total hot run time: 26617 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 13594af7e2865f00fa0a4d95bd7097d6f12b5383, data reload: false

------ Round 1 ----------------------------------
orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	17640	4447	4303	4303
q2	q3	10648	791	522	522
q4	4685	364	256	256
q5	7560	1217	1013	1013
q6	178	175	149	149
q7	782	843	657	657
q8	9297	1655	1319	1319
q9	4819	4802	4767	4767
q10	6248	1909	1665	1665
q11	455	258	251	251
q12	721	585	468	468
q13	18039	2758	1946	1946
q14	226	239	210	210
q15	q16	717	730	662	662
q17	713	838	444	444
q18	5888	5344	5301	5301
q19	1113	979	618	618
q20	545	490	377	377
q21	4506	1840	1397	1397
q22	341	292	369	292
Total cold run time: 95121 ms
Total hot run time: 26617 ms

----- Round 2, with runtime_filter_mode=off -----
orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	4785	4666	4597	4597
q2	q3	3884	4353	3840	3840
q4	885	1194	777	777
q5	4065	4421	4326	4326
q6	187	180	146	146
q7	1787	1705	1564	1564
q8	2495	2724	2543	2543
q9	7626	7186	7284	7186
q10	3804	4043	3572	3572
q11	506	445	426	426
q12	510	601	449	449
q13	2515	2968	2060	2060
q14	294	329	297	297
q15	q16	752	800	717	717
q17	1156	1348	1342	1342
q18	7199	6664	6667	6664
q19	940	880	894	880
q20	2120	2117	2050	2050
q21	4103	3513	3338	3338
q22	486	415	397	397
Total cold run time: 50099 ms
Total hot run time: 47171 ms

hello-stephen · 2026-03-31T13:53:52Z

FE UT Coverage Report

Increment line coverage `` 🎉
Increment coverage report
Complete coverage report

JNSimba · 2026-03-31T13:55:27Z

run external

doris-robot · 2026-03-31T14:33:25Z

TPC-H: Total hot run time: 26701 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 13594af7e2865f00fa0a4d95bd7097d6f12b5383, data reload: false

------ Round 1 ----------------------------------
orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	17652	4448	4302	4302
q2	q3	10641	768	528	528
q4	4675	363	248	248
q5	7590	1201	1027	1027
q6	187	172	149	149
q7	797	842	674	674
q8	9379	1468	1348	1348
q9	4870	4770	4767	4767
q10	6322	1920	1683	1683
q11	459	259	245	245
q12	749	591	466	466
q13	18032	2672	1945	1945
q14	225	241	211	211
q15	q16	727	743	673	673
q17	763	854	428	428
q18	5914	5511	5264	5264
q19	1144	981	634	634
q20	542	489	372	372
q21	4576	1836	1436	1436
q22	502	456	301	301
Total cold run time: 95746 ms
Total hot run time: 26701 ms

----- Round 2, with runtime_filter_mode=off -----
orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	4781	4711	4603	4603
q2	q3	3886	4421	3945	3945
q4	877	1283	823	823
q5	4137	4476	4432	4432
q6	192	183	144	144
q7	1764	1614	1554	1554
q8	2460	2735	2569	2569
q9	7589	7469	7478	7469
q10	3812	3942	3635	3635
q11	495	428	409	409
q12	500	671	495	495
q13	2486	2931	2095	2095
q14	296	310	299	299
q15	q16	744	755	703	703
q17	1179	1346	1382	1346
q18	7284	6989	6581	6581
q19	968	958	950	950
q20	2087	2126	1981	1981
q21	3960	3468	3343	3343
q22	468	435	389	389
Total cold run time: 49965 ms
Total hot run time: 47765 ms

doris-robot · 2026-03-31T14:44:13Z

TPC-DS: Total hot run time: 169289 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 13594af7e2865f00fa0a4d95bd7097d6f12b5383, data reload: false

query5	4335	627	507	507
query6	330	218	200	200
query7	4226	482	264	264
query8	335	241	226	226
query9	8692	2723	2716	2716
query10	523	374	330	330
query11	6937	5144	4859	4859
query12	180	127	127	127
query13	1282	466	359	359
query14	5705	3765	3535	3535
query14_1	2903	2849	2913	2849
query15	205	195	179	179
query16	985	466	443	443
query17	1125	740	624	624
query18	2464	462	350	350
query19	221	209	191	191
query20	134	125	124	124
query21	212	143	112	112
query22	13171	13846	14636	13846
query23	16696	16357	16157	16157
query23_1	16146	15764	15652	15652
query24	7160	1622	1219	1219
query24_1	1238	1229	1245	1229
query25	536	461	413	413
query26	1245	273	150	150
query27	2769	481	293	293
query28	4489	1849	1852	1849
query29	840	569	497	497
query30	294	228	190	190
query31	1015	956	877	877
query32	78	73	70	70
query33	509	327	284	284
query34	892	888	526	526
query35	687	679	600	600
query36	1084	1124	991	991
query37	133	95	80	80
query38	3029	2925	2876	2876
query39	860	838	842	838
query39_1	824	819	814	814
query40	233	154	136	136
query41	62	60	57	57
query42	261	258	257	257
query43	246	256	235	235
query44	
query45	203	190	184	184
query46	929	1018	626	626
query47	2105	2111	2110	2110
query48	340	318	238	238
query49	640	465	391	391
query50	730	282	207	207
query51	4129	4050	4060	4050
query52	263	262	258	258
query53	296	339	290	290
query54	312	270	260	260
query55	97	88	83	83
query56	301	329	312	312
query57	1939	1863	1658	1658
query58	284	272	266	266
query59	2820	2928	2767	2767
query60	348	336	327	327
query61	159	154	157	154
query62	642	595	545	545
query63	312	283	277	277
query64	5063	1291	1020	1020
query65	
query66	1476	446	355	355
query67	24244	24379	24239	24239
query68	
query69	413	325	293	293
query70	1000	1023	956	956
query71	336	305	294	294
query72	2827	2697	2461	2461
query73	545	565	333	333
query74	9654	9601	9422	9422
query75	2873	2784	2474	2474
query76	2270	1056	685	685
query77	364	402	326	326
query78	10961	11042	10522	10522
query79	1431	804	576	576
query80	1328	644	574	574
query81	553	270	230	230
query82	1015	156	124	124
query83	331	268	252	252
query84	264	122	103	103
query85	982	531	463	463
query86	405	317	329	317
query87	3117	3107	2981	2981
query88	3588	2700	2682	2682
query89	459	376	347	347
query90	2011	181	176	176
query91	165	165	139	139
query92	74	87	67	67
query93	997	850	497	497
query94	651	318	271	271
query95	596	406	320	320
query96	657	515	235	235
query97	2479	2539	2403	2403
query98	238	220	217	217
query99	1012	1006	914	914
Total cold run time: 250497 ms
Total hot run time: 169289 ms

JNSimba · 2026-04-01T03:15:03Z

run buildall

JNSimba · 2026-04-01T03:18:54Z

run buildall

doris-robot · 2026-04-01T03:51:49Z

TPC-H: Total hot run time: 26636 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0527c4769b7e3399d4274ae6f7cb85a1465593d3, data reload: false

------ Round 1 ----------------------------------
orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	17645	4511	4322	4322
q2	q3	10666	800	510	510
q4	4681	357	257	257
q5	7578	1196	1033	1033
q6	178	174	148	148
q7	792	894	684	684
q8	9305	1477	1328	1328
q9	4878	4754	4658	4658
q10	6292	1928	1646	1646
q11	459	257	238	238
q12	766	578	467	467
q13	18037	2691	1980	1980
q14	230	230	214	214
q15	q16	741	725	665	665
q17	732	833	447	447
q18	5897	5416	5313	5313
q19	1118	982	613	613
q20	524	486	374	374
q21	4502	1851	1425	1425
q22	353	314	476	314
Total cold run time: 95374 ms
Total hot run time: 26636 ms

----- Round 2, with runtime_filter_mode=off -----
orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	4814	4702	4732	4702
q2	q3	4005	4386	3855	3855
q4	871	1195	801	801
q5	4079	4356	4407	4356
q6	190	175	145	145
q7	1733	1684	1510	1510
q8	2494	2723	2561	2561
q9	7623	7324	7427	7324
q10	3867	4094	3547	3547
q11	511	437	417	417
q12	482	574	456	456
q13	2443	2967	2148	2148
q14	308	317	309	309
q15	q16	787	754	710	710
q17	1198	1390	1369	1369
q18	7135	6767	6602	6602
q19	883	896	889	889
q20	2068	2199	2019	2019
q21	3957	3480	3289	3289
q22	445	420	365	365
Total cold run time: 49893 ms
Total hot run time: 47374 ms

doris-robot · 2026-04-01T04:02:38Z

TPC-DS: Total hot run time: 170015 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0527c4769b7e3399d4274ae6f7cb85a1465593d3, data reload: false

query5	4331	642	505	505
query6	333	221	205	205
query7	4224	449	262	262
query8	342	241	235	235
query9	8699	2732	2746	2732
query10	532	400	340	340
query11	7000	5096	4899	4899
query12	178	130	131	130
query13	1272	462	351	351
query14	5767	3701	3511	3511
query14_1	2911	2844	2913	2844
query15	212	205	179	179
query16	992	463	445	445
query17	895	736	632	632
query18	2448	457	362	362
query19	218	213	198	198
query20	138	131	129	129
query21	220	134	124	124
query22	13183	14220	14850	14220
query23	16562	16428	16018	16018
query23_1	16129	16334	15906	15906
query24	7205	1610	1229	1229
query24_1	1208	1228	1243	1228
query25	594	522	414	414
query26	1245	266	148	148
query27	2767	484	299	299
query28	4967	1856	1871	1856
query29	868	587	495	495
query30	300	226	199	199
query31	1003	953	885	885
query32	84	73	72	72
query33	504	346	297	297
query34	893	876	545	545
query35	634	703	615	615
query36	1141	1185	1043	1043
query37	138	94	84	84
query38	2947	2944	2963	2944
query39	859	837	815	815
query39_1	806	809	810	809
query40	238	151	134	134
query41	64	61	62	61
query42	260	257	257	257
query43	244	259	218	218
query44	
query45	198	191	185	185
query46	900	991	632	632
query47	2130	2121	2058	2058
query48	307	310	240	240
query49	625	466	387	387
query50	688	275	212	212
query51	4064	4111	4007	4007
query52	265	265	257	257
query53	296	342	302	302
query54	309	276	272	272
query55	93	89	83	83
query56	333	341	318	318
query57	1928	1723	1615	1615
query58	289	283	272	272
query59	2803	2962	2767	2767
query60	343	353	337	337
query61	149	147	157	147
query62	638	588	560	560
query63	317	281	276	276
query64	5096	1308	1004	1004
query65	
query66	1459	446	354	354
query67	24314	24340	24222	24222
query68	
query69	407	319	301	301
query70	1002	957	926	926
query71	329	303	309	303
query72	2831	2743	2645	2645
query73	530	541	337	337
query74	9645	9594	9399	9399
query75	2878	2757	2456	2456
query76	2298	1042	703	703
query77	393	384	319	319
query78	10937	11201	10457	10457
query79	1107	787	586	586
query80	1355	632	542	542
query81	542	267	224	224
query82	985	160	119	119
query83	341	272	249	249
query84	298	119	103	103
query85	909	505	462	462
query86	423	312	285	285
query87	3137	3166	3019	3019
query88	3540	2671	2668	2668
query89	426	377	354	354
query90	2033	185	177	177
query91	172	162	151	151
query92	80	76	72	72
query93	929	846	499	499
query94	646	326	310	310
query95	589	347	322	322
query96	644	512	227	227
query97	2441	2483	2410	2410
query98	236	220	222	220
query99	1011	1011	900	900
Total cold run time: 250523 ms
Total hot run time: 170015 ms

JNSimba · 2026-04-01T06:05:30Z

run buildall

JNSimba · 2026-04-01T06:49:33Z

run buildall

hello-stephen · 2026-04-01T08:06:13Z

FE UT Coverage Report

Increment line coverage 0.00% (0/4) 🎉
Increment coverage report
Complete coverage report

JNSimba · 2026-04-01T08:46:36Z

run nonConcurrent

JNSimba · 2026-04-01T08:46:46Z

run performance

doris-robot · 2026-04-01T10:56:29Z

TPC-H: Total hot run time: 29237 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5a5b4a042a0046ab06a6084551b40383281856f1, data reload: false

------ Round 1 ----------------------------------
orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	17621	3811	3682	3682
q2	q3	10685	863	594	594
q4	4679	465	365	365
q5	7446	1364	1174	1174
q6	190	163	145	145
q7	924	956	790	790
q8	9320	1385	1313	1313
q9	5457	5343	5240	5240
q10	6283	2041	1778	1778
q11	478	284	282	282
q12	806	705	510	510
q13	18054	2782	2163	2163
q14	286	290	258	258
q15	q16	856	870	791	791
q17	1060	1161	832	832
q18	6384	5643	5498	5498
q19	1171	1291	1073	1073
q20	603	561	402	402
q21	4263	2520	2003	2003
q22	466	410	344	344
Total cold run time: 97032 ms
Total hot run time: 29237 ms

----- Round 2, with runtime_filter_mode=off -----
orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	4673	4484	4633	4484
q2	q3	4640	4775	4215	4215
q4	2105	2232	1359	1359
q5	4914	4961	5231	4961
q6	192	171	142	142
q7	2047	1798	1611	1611
q8	3446	3045	3072	3045
q9	8189	8209	8177	8177
q10	4443	4433	4317	4317
q11	573	402	375	375
q12	679	720	505	505
q13	2758	3098	2425	2425
q14	295	305	285	285
q15	q16	752	780	689	689
q17	1284	1267	1269	1267
q18	7857	6891	7186	6891
q19	1117	1101	1146	1101
q20	2222	2206	1993	1993
q21	5981	5367	5071	5071
q22	549	509	424	424
Total cold run time: 58716 ms
Total hot run time: 53337 ms

doris-robot · 2026-04-01T11:07:51Z

TPC-DS: Total hot run time: 180518 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5a5b4a042a0046ab06a6084551b40383281856f1, data reload: false

query5	4350	665	538	538
query6	355	237	212	212
query7	4295	601	324	324
query8	333	254	223	223
query9	8732	3966	3977	3966
query10	500	413	351	351
query11	6961	5493	5156	5156
query12	186	139	128	128
query13	1277	619	456	456
query14	5709	5190	4789	4789
query14_1	4172	4161	4131	4131
query15	215	203	184	184
query16	993	426	440	426
query17	980	797	660	660
query18	2538	512	393	393
query19	256	235	198	198
query20	139	135	135	135
query21	225	146	127	127
query22	13983	14879	14568	14568
query23	17985	17351	16552	16552
query23_1	16781	16697	16949	16697
query24	7459	1745	1390	1390
query24_1	1348	1379	1320	1320
query25	580	490	441	441
query26	1253	317	183	183
query27	2702	601	373	373
query28	4508	1900	1875	1875
query29	976	650	543	543
query30	297	236	198	198
query31	1092	1060	941	941
query32	95	71	72	71
query33	534	340	288	288
query34	1199	1163	700	700
query35	748	768	666	666
query36	1233	1185	1135	1135
query37	152	95	85	85
query38	3116	3029	2987	2987
query39	929	902	848	848
query39_1	835	822	831	822
query40	240	154	136	136
query41	65	59	60	59
query42	280	273	275	273
query43	319	321	274	274
query44	
query45	212	196	190	190
query46	1200	1248	794	794
query47	2351	2333	2231	2231
query48	393	398	297	297
query49	649	528	427	427
query50	736	287	215	215
query51	4352	4281	4294	4281
query52	278	285	266	266
query53	326	355	295	295
query54	334	295	265	265
query55	97	95	87	87
query56	331	333	325	325
query57	1775	1651	1596	1596
query58	292	269	273	269
query59	2890	3018	2765	2765
query60	341	335	326	326
query61	160	157	155	155
query62	696	622	553	553
query63	315	289	296	289
query64	5368	1448	1093	1093
query65	
query66	1481	477	392	392
query67	24453	24308	24268	24268
query68	
query69	465	341	321	321
query70	1034	1000	1017	1000
query71	371	335	311	311
query72	3058	2703	2446	2446
query73	816	772	484	484
query74	9852	9737	9602	9602
query75	3575	3357	3011	3011
query76	2299	1131	766	766
query77	401	427	341	341
query78	11354	11393	10760	10760
query79	1580	1121	824	824
query80	831	743	665	665
query81	474	278	241	241
query82	1375	163	124	124
query83	388	286	269	269
query84	310	145	118	118
query85	919	515	456	456
query86	403	336	294	294
query87	3283	3203	3136	3136
query88	3592	2739	2704	2704
query89	497	422	387	387
query90	1986	178	168	168
query91	182	174	145	145
query92	82	77	66	66
query93	906	899	507	507
query94	550	322	294	294
query95	666	469	341	341
query96	1046	759	350	350
query97	2680	2670	2576	2576
query98	243	228	226	226
query99	1100	1045	962	962
Total cold run time: 259526 ms
Total hot run time: 180518 ms

JNSimba · 2026-04-02T04:13:41Z

run buildall

doris-robot · 2026-04-02T04:42:31Z

TPC-H: Total hot run time: 29257 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 745ea164d38d4e56ec056d396b9dee7a7155043c, data reload: false

------ Round 1 ----------------------------------
orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	17604	3720	3712	3712
q2	q3	10671	856	620	620
q4	4689	471	359	359
q5	7475	1312	1129	1129
q6	183	164	139	139
q7	898	954	774	774
q8	9310	1380	1355	1355
q9	5483	5334	5220	5220
q10	6323	2043	1755	1755
q11	484	285	281	281
q12	836	693	508	508
q13	18028	2793	2164	2164
q14	283	284	260	260
q15	q16	895	864	781	781
q17	1110	1113	842	842
q18	6410	5646	5482	5482
q19	1158	1259	1104	1104
q20	611	549	403	403
q21	4671	2437	2025	2025
q22	478	412	344	344
Total cold run time: 97600 ms
Total hot run time: 29257 ms

----- Round 2, with runtime_filter_mode=off -----
orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	4451	4431	4212	4212
q2	q3	4591	4761	4204	4204
q4	2106	2208	1396	1396
q5	4947	4966	5200	4966
q6	193	166	137	137
q7	2038	1757	1631	1631
q8	3267	3099	3125	3099
q9	8363	8469	8265	8265
q10	4442	4465	4253	4253
q11	579	404	394	394
q12	841	725	482	482
q13	2702	2981	2325	2325
q14	308	306	277	277
q15	q16	784	773	692	692
q17	1289	1284	1215	1215
q18	7829	7039	7117	7039
q19	1150	1148	1096	1096
q20	2211	2194	1963	1963
q21	6020	5652	4874	4874
q22	535	486	420	420
Total cold run time: 58646 ms
Total hot run time: 52940 ms

doris-robot · 2026-04-02T04:53:55Z

TPC-DS: Total hot run time: 180338 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 745ea164d38d4e56ec056d396b9dee7a7155043c, data reload: false

query5	4356	651	486	486
query6	350	236	212	212
query7	4241	587	328	328
query8	347	249	229	229
query9	8738	3904	3891	3891
query10	505	409	367	367
query11	6650	5503	5094	5094
query12	190	128	135	128
query13	1283	621	441	441
query14	5700	5187	4767	4767
query14_1	4149	4146	4139	4139
query15	220	204	183	183
query16	1026	481	439	439
query17	1170	794	655	655
query18	2624	515	382	382
query19	273	234	198	198
query20	153	133	133	133
query21	227	148	122	122
query22	14091	14703	14572	14572
query23	18106	17139	16694	16694
query23_1	17072	16889	16708	16708
query24	8200	1800	1380	1380
query24_1	1371	1366	1382	1366
query25	644	482	438	438
query26	1278	344	175	175
query27	2640	630	377	377
query28	4433	1897	1902	1897
query29	986	675	572	572
query30	300	236	196	196
query31	1095	1054	936	936
query32	87	74	71	71
query33	528	328	291	291
query34	1229	1165	661	661
query35	746	779	680	680
query36	1266	1234	1152	1152
query37	157	97	82	82
query38	3104	3055	3048	3048
query39	914	892	857	857
query39_1	837	853	838	838
query40	232	154	139	139
query41	64	62	58	58
query42	279	270	309	270
query43	324	324	286	286
query44	
query45	208	201	190	190
query46	1171	1221	822	822
query47	2329	2325	2239	2239
query48	434	398	313	313
query49	640	532	444	444
query50	736	277	216	216
query51	4493	4278	4217	4217
query52	278	282	273	273
query53	325	345	279	279
query54	321	290	267	267
query55	99	94	87	87
query56	331	336	321	321
query57	1722	1678	1594	1594
query58	304	284	272	272
query59	2930	2977	2724	2724
query60	337	343	333	333
query61	160	158	161	158
query62	698	626	544	544
query63	314	274	271	271
query64	5362	1479	1116	1116
query65	
query66	1431	476	386	386
query67	24386	24291	24313	24291
query68	
query69	443	346	315	315
query70	1017	1007	982	982
query71	360	328	333	328
query72	2981	2723	2474	2474
query73	790	808	409	409
query74	9838	9736	9540	9540
query75	3605	3380	3043	3043
query76	2318	1142	744	744
query77	423	415	347	347
query78	11278	11411	10769	10769
query79	2358	1108	789	789
query80	1421	752	682	682
query81	521	276	239	239
query82	984	165	125	125
query83	356	296	264	264
query84	265	145	118	118
query85	958	512	456	456
query86	466	308	332	308
query87	3270	3222	3084	3084
query88	3632	2679	2663	2663
query89	480	413	382	382
query90	1928	187	181	181
query91	181	176	144	144
query92	75	80	71	71
query93	1199	883	503	503
query94	710	347	289	289
query95	662	465	338	338
query96	1078	794	348	348
query97	2708	2677	2580	2580
query98	242	231	228	228
query99	1070	1081	963	963
Total cold run time: 262324 ms
Total hot run time: 180338 ms

JNSimba · 2026-04-02T06:38:02Z

run p0

JNSimba · 2026-04-02T07:26:44Z

run p0

liaoxin01

LGTM

github-actions · 2026-04-02T08:46:00Z

PR approved by at least one committer and no changes requested.

JNSimba · 2026-04-02T09:45:55Z

run p0

…#61894) ## What problem does this PR solve? Problem Summary: - `StreamingInsertJob` does not support manual task cancellation - `cancelAllTasks()` is only triggered internally when job is STOPPED or PAUSED, meaning the task was interrupted passively - Change `canceledTaskCount.incrementAndGet()` in `cancelAllTasks()`, when task is running `canceledTaskCount` need incr

…nceled tasks #61894 (#62055) Cherry-picked from #61894 Co-authored-by: wudi <wudi@selectdb.com>

JNSimba added dev/4.1.x dev/4.0.x labels Mar 30, 2026

sollhui approved these changes Mar 31, 2026

View reviewed changes

github-actions bot added the reviewed label Mar 31, 2026

liaoxin01 previously approved these changes Mar 31, 2026

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 31, 2026

fix

13594af

JNSimba dismissed liaoxin01’s stale review via 13594af March 31, 2026 12:39

github-actions bot removed the approved Indicates a PR has been approved by one committer. label Mar 31, 2026

fix

7cbb3ef

fix

0527c47

fix

5a5b4a0

JNSimba force-pushed the fix_failcount_streamjob branch from 92fc2b2 to 5a5b4a0 Compare April 1, 2026 10:46

Merge branch 'master' into fix_failcount_streamjob

745ea16

liaoxin01 approved these changes Apr 2, 2026

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 2, 2026

JNSimba removed the dev/4.0.x label Apr 2, 2026

JNSimba merged commit 8e706d1 into apache:master Apr 2, 2026
28 of 29 checks passed

github-actions bot mentioned this pull request Apr 2, 2026

branch-4.1: [fix](job) fix StreamingInsertJob incorrectly counting canceled tasks #61894 #62055

Merged

yiguolei pushed a commit that referenced this pull request Apr 3, 2026

branch-4.1: [fix](job) fix StreamingInsertJob incorrectly counting ca…

b03b432

…nceled tasks #61894 (#62055) Cherry-picked from #61894 Co-authored-by: wudi <wudi@selectdb.com>

yiguolei added dev/4.1.0-merged and removed dev/4.1.x labels Apr 3, 2026

Conversation

JNSimba commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Test plan

Uh oh!

Thearas commented Mar 30, 2026

Uh oh!

JNSimba commented Mar 30, 2026

Uh oh!

doris-robot commented Mar 30, 2026

Uh oh!

doris-robot commented Mar 30, 2026

Uh oh!

JNSimba commented Mar 31, 2026

Uh oh!

sollhui left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

liaoxin01 left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

JNSimba commented Mar 31, 2026

Uh oh!

doris-robot commented Mar 31, 2026

Uh oh!

hello-stephen commented Mar 31, 2026

FE UT Coverage Report

Uh oh!

JNSimba commented Mar 31, 2026

Uh oh!

doris-robot commented Mar 31, 2026

Uh oh!

doris-robot commented Mar 31, 2026

Uh oh!

JNSimba commented Apr 1, 2026

Uh oh!

JNSimba commented Apr 1, 2026

Uh oh!

doris-robot commented Apr 1, 2026

Uh oh!

doris-robot commented Apr 1, 2026

Uh oh!

JNSimba commented Apr 1, 2026

Uh oh!

JNSimba commented Apr 1, 2026

Uh oh!

hello-stephen commented Apr 1, 2026

FE UT Coverage Report

Uh oh!

JNSimba commented Apr 1, 2026

Uh oh!

JNSimba commented Apr 1, 2026

Uh oh!

doris-robot commented Apr 1, 2026

Uh oh!

doris-robot commented Apr 1, 2026

Uh oh!

JNSimba commented Apr 2, 2026

Uh oh!

doris-robot commented Apr 2, 2026

Uh oh!

doris-robot commented Apr 2, 2026

Uh oh!

JNSimba commented Apr 2, 2026

Uh oh!

JNSimba commented Apr 2, 2026

Uh oh!

liaoxin01 left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 2, 2026

Uh oh!

JNSimba commented Apr 2, 2026

Uh oh!

Uh oh!

JNSimba commented Mar 30, 2026 •

edited

Loading