Skip to content

[enhancement](config) Change segments_key_bounds_truncation_threshold default to 36#61984

Merged
gavinchou merged 1 commit intoapache:masterfrom
bobhan1:change-segments-key-bounds-truncation-default-to-36
Apr 1, 2026
Merged

[enhancement](config) Change segments_key_bounds_truncation_threshold default to 36#61984
gavinchou merged 1 commit intoapache:masterfrom
bobhan1:change-segments-key-bounds-truncation-default-to-36

Conversation

@bobhan1
Copy link
Copy Markdown
Contributor

@bobhan1 bobhan1 commented Apr 1, 2026

Enable segments key bounds truncation by default with threshold 36 bytes to reduce rowset metadata memory usage.

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

… default to 36

Enable segments key bounds truncation by default with threshold 36 bytes
to reduce rowset metadata memory usage.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@Thearas
Copy link
Copy Markdown
Contributor

Thearas commented Apr 1, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@bobhan1
Copy link
Copy Markdown
Contributor Author

bobhan1 commented Apr 1, 2026

run buildall

Copy link
Copy Markdown
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 1, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

PR approved by anyone and no changes requested.

@doris-robot
Copy link
Copy Markdown

TPC-H: Total hot run time: 26811 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f67d9fd1cb434fc8c78f81ed7918d5280123dafd, data reload: false

------ Round 1 ----------------------------------
orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	17608	4487	4313	4313
q2	q3	10667	811	524	524
q4	4679	353	252	252
q5	7575	1226	1020	1020
q6	181	172	151	151
q7	787	878	701	701
q8	9314	1547	1411	1411
q9	4866	4818	4753	4753
q10	6244	1908	1647	1647
q11	453	258	262	258
q12	744	574	462	462
q13	18014	2710	2053	2053
q14	235	229	212	212
q15	q16	726	742	680	680
q17	748	853	463	463
q18	5888	5340	5115	5115
q19	1121	981	634	634
q20	529	497	381	381
q21	4479	1891	1470	1470
q22	347	311	421	311
Total cold run time: 95205 ms
Total hot run time: 26811 ms

----- Round 2, with runtime_filter_mode=off -----
orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	4854	4649	4641	4641
q2	q3	3869	4384	3838	3838
q4	921	1208	773	773
q5	4106	4433	4352	4352
q6	188	186	145	145
q7	1882	1691	1548	1548
q8	2535	2745	2559	2559
q9	7705	7465	7419	7419
q10	3813	4054	3608	3608
q11	518	434	417	417
q12	518	590	432	432
q13	2505	2892	2154	2154
q14	288	301	290	290
q15	q16	726	825	741	741
q17	1200	1298	1302	1298
q18	7200	6686	6560	6560
q19	1003	953	1065	953
q20	2107	2193	2054	2054
q21	4024	3554	3324	3324
q22	468	428	399	399
Total cold run time: 50430 ms
Total hot run time: 47505 ms

@doris-robot
Copy link
Copy Markdown

TPC-DS: Total hot run time: 168968 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f67d9fd1cb434fc8c78f81ed7918d5280123dafd, data reload: false

query5	4359	657	520	520
query6	344	227	207	207
query7	4222	480	263	263
query8	349	239	235	235
query9	8709	2681	2673	2673
query10	522	401	344	344
query11	6959	5116	4883	4883
query12	184	137	143	137
query13	1275	480	346	346
query14	5722	3699	3431	3431
query14_1	2886	2875	2826	2826
query15	210	200	177	177
query16	993	464	456	456
query17	954	735	629	629
query18	2459	459	357	357
query19	222	213	188	188
query20	135	129	131	129
query21	217	137	113	113
query22	13303	14063	14716	14063
query23	16725	16611	15979	15979
query23_1	15866	15670	15757	15670
query24	7270	1630	1223	1223
query24_1	1268	1242	1210	1210
query25	531	467	403	403
query26	1232	265	154	154
query27	2776	497	300	300
query28	4472	1823	1832	1823
query29	799	565	483	483
query30	298	228	190	190
query31	1025	939	896	896
query32	88	72	73	72
query33	508	341	295	295
query34	895	893	531	531
query35	642	676	604	604
query36	1052	1146	990	990
query37	145	99	83	83
query38	2941	2935	2850	2850
query39	849	848	813	813
query39_1	790	798	801	798
query40	232	197	135	135
query41	63	58	59	58
query42	272	263	264	263
query43	248	260	224	224
query44	
query45	205	196	180	180
query46	891	988	604	604
query47	2125	2129	2050	2050
query48	314	343	235	235
query49	633	468	390	390
query50	721	285	217	217
query51	4099	4056	3976	3976
query52	267	268	252	252
query53	301	334	286	286
query54	308	283	262	262
query55	91	86	84	84
query56	330	323	302	302
query57	1916	1877	1776	1776
query58	290	273	294	273
query59	2839	2987	2758	2758
query60	344	339	325	325
query61	164	152	158	152
query62	630	589	541	541
query63	306	271	274	271
query64	5000	1278	1012	1012
query65	
query66	1449	451	348	348
query67	24249	24259	24266	24259
query68	
query69	408	327	295	295
query70	977	949	947	947
query71	361	314	299	299
query72	2831	2780	2465	2465
query73	552	559	315	315
query74	9651	9566	9434	9434
query75	2875	2794	2430	2430
query76	2292	1034	696	696
query77	376	410	300	300
query78	10898	11159	10440	10440
query79	1143	777	588	588
query80	1330	617	549	549
query81	518	260	230	230
query82	1323	162	130	130
query83	341	276	241	241
query84	290	113	103	103
query85	937	507	459	459
query86	420	333	298	298
query87	3141	3132	3022	3022
query88	3638	2664	2661	2661
query89	435	364	346	346
query90	2020	192	175	175
query91	174	167	140	140
query92	81	75	72	72
query93	973	854	501	501
query94	633	295	316	295
query95	591	346	326	326
query96	659	537	230	230
query97	2486	2492	2400	2400
query98	240	219	220	219
query99	1009	996	913	913
Total cold run time: 249629 ms
Total hot run time: 168968 ms

@doris-robot
Copy link
Copy Markdown

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.93% (19994/37775)
Line Coverage 36.48% (187623/514263)
Region Coverage 32.69% (145319/444507)
Branch Coverage 33.89% (63768/188152)

@hello-stephen
Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 73.52% (27197/36994)
Line Coverage 57.14% (292953/512719)
Region Coverage 54.41% (244086/448625)
Branch Coverage 56.10% (105867/188718)

@gavinchou gavinchou merged commit 464a727 into apache:master Apr 1, 2026
32 of 34 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 1, 2026
… default to 36 (#61984)

Enable segments key bounds truncation by default with threshold 36 bytes to reduce rowset metadata memory usage.
github-actions bot pushed a commit that referenced this pull request Apr 1, 2026
… default to 36 (#61984)

Enable segments key bounds truncation by default with threshold 36 bytes to reduce rowset metadata memory usage.
morningman pushed a commit that referenced this pull request Apr 2, 2026
… default to 36 (#61984)

Enable segments key bounds truncation by default with threshold 36 bytes to reduce rowset metadata memory usage.
yiguolei pushed a commit that referenced this pull request Apr 3, 2026
…on_threshold default to 36 #61984 (#62003)

Cherry-picked from #61984

Co-authored-by: bobhan1 <baohan@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.x dev/4.1.0-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants