Skip to content

branch-4.0: [fix](load)fix VNodeChannel close_wait hang #58024#62030

Open
wyxxxcat wants to merge 1 commit intoapache:branch-4.0from
wyxxxcat:pick_58024_4_0
Open

branch-4.0: [fix](load)fix VNodeChannel close_wait hang #58024#62030
wyxxxcat wants to merge 1 commit intoapache:branch-4.0from
wyxxxcat:pick_58024_4_0

Conversation

@wyxxxcat
Copy link
Copy Markdown
Collaborator

@wyxxxcat wyxxxcat commented Apr 2, 2026

pick: #58024

During streamload execution, close_wait waits for either
add_batches_finished or cancel. When writing to a single replica,
encountering a slave node=nullptr condition causes an early return. If
no RPC callback is set and no cancel occurs at this point, close_wait
becomes deadlock.
@wyxxxcat wyxxxcat requested a review from yiguolei as a code owner April 2, 2026 02:40
@Thearas
Copy link
Copy Markdown
Contributor

Thearas commented Apr 2, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wyxxxcat
Copy link
Copy Markdown
Collaborator Author

wyxxxcat commented Apr 2, 2026

run buildall

@hello-stephen
Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/10) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.90% (19233/36359)
Line Coverage 36.09% (179137/496386)
Region Coverage 32.73% (139146/425094)
Branch Coverage 33.65% (60304/179186)

@hello-stephen
Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 0.00% (0/10) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.35% (25394/35593)
Line Coverage 54.07% (267911/495492)
Region Coverage 51.67% (221838/429367)
Branch Coverage 53.07% (95438/179829)

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 2, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

PR approved by anyone and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants