branch-4.1: [fix](iceberg) Avoid dict reads on mixed-encoding position delete files #61759#62036
Open
github-actions[bot] wants to merge 1 commit intobranch-4.1from
Open
branch-4.1: [fix](iceberg) Avoid dict reads on mixed-encoding position delete files #61759#62036github-actions[bot] wants to merge 1 commit intobranch-4.1from
github-actions[bot] wants to merge 1 commit intobranch-4.1from
Conversation
…es (#61759) ### What problem does this PR solve? Iceberg parquet position delete files currently treat the `file_path` column as dictionary-coded as long as the column chunk has a dictionary page. That check is too loose: parquet allows mixed encodings in the same column chunk, so a chunk can contain both dictionary-encoded and plain-encoded data pages. When that happens, Doris builds a `ColumnDictI32` for `file_path`, but the plain decoder later calls `insert_many_strings()`, which fails with: `Method insert_many_strings is not supported for ColumnDictionary` This PR fixes the issue by only using dictionary-backed decoding for Iceberg position delete `file_path` columns when the entire parquet column chunk is fully dictionary encoded. Mixed-encoding chunks now fall back to normal string columns. It also adds BE unit coverage for: - fully dictionary-encoded parquet metadata - mixed dictionary/plain parquet metadata - parquet metadata without `encoding_stats` but with non-dictionary encodings
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #61759