[refine](expr) Replace manual type switch-case with dispatch_switch helpers#62042
Open
Mryange wants to merge 2 commits intoapache:masterfrom
Open
[refine](expr) Replace manual type switch-case with dispatch_switch helpers#62042Mryange wants to merge 2 commits intoapache:masterfrom
Mryange wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 29219 ms |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-DS: Total hot run time: 180443 ms |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Several aggregate/scalar functions in
be/src/exprs/use large hand-written switch-case blocks to dispatch onPrimitiveType. These are verbose, error-prone, and generate repetitive boilerplate.This PR replaces them with the existing
dispatch_switch_scalar/dispatch_switch_numberutilities fromcall_on_type_index.h:least_greast.cpp(FunctionFieldImpl::execute): ~15 manual cases →dispatch_switch_scalaraggregate_function_group_array_set_op_impl.h: ~16 manual cases →dispatch_switch_scalar+ string branchfunction_array_cum_sum.cpp(_execute_by_type): ~13 manual cases →dispatch_switch_numberwithconstexpr iftype promotionRelease note
None
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)