Skip to content

[fix](local shuffle) fix bucket shuffle exchange incorrectly marked as serial in pooling mode#62054

Open
924060929 wants to merge 1 commit intoapache:masterfrom
924060929:opt_bucket_shuffle_exchange
Open

[fix](local shuffle) fix bucket shuffle exchange incorrectly marked as serial in pooling mode#62054
924060929 wants to merge 1 commit intoapache:masterfrom
924060929:opt_bucket_shuffle_exchange

Conversation

@924060929
Copy link
Copy Markdown
Contributor

@924060929 924060929 commented Apr 2, 2026

  1. ExchangeNode.isSerialOperator(): move useSerialSource() guard into isSerialOperator()
       so that is_serial is a self-contained per-operator property. Only UNPARTITIONED or
       use_serial_exchange exchanges in pooling mode are serial. Bucket shuffle / hash
       exchanges are never serial — scan seriality is handled by the scan pipeline independently.

  2. DistributePlanner.filterInstancesWhichCanReceiveDataFromRemote(): use
       linkNode.isSerialOperator() to decide whether to dedupe to first-per-worker.
       Remove LocalShuffleAssignedJob type check and enableShareHashTableForBroadcastJoin
       parameter — serial exchange semantics already capture the correct behavior.

  3. Add unit tests for both changes.

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Copy Markdown
Contributor

Thearas commented Apr 2, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

…s serial in pooling mode

1. ExchangeNode.isSerialOperator(): move useSerialSource() guard into isSerialOperator()
   so that is_serial is a self-contained per-operator property. Only UNPARTITIONED or
   use_serial_exchange exchanges in pooling mode are serial. Bucket shuffle / hash
   exchanges are never serial — scan seriality is handled by the scan pipeline independently.

2. DistributePlanner.filterInstancesWhichCanReceiveDataFromRemote(): use
   linkNode.isSerialOperator() to decide whether to dedupe to first-per-worker.
   Remove LocalShuffleAssignedJob type check and enableShareHashTableForBroadcastJoin
   parameter — serial exchange semantics already capture the correct behavior.

3. Add unit tests for both changes.
@924060929 924060929 force-pushed the opt_bucket_shuffle_exchange branch from e935b63 to 4c3e765 Compare April 2, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants