[fix](local shuffle) fix bucket shuffle exchange incorrectly marked as serial in pooling mode#62054
Open
924060929 wants to merge 1 commit intoapache:masterfrom
Open
[fix](local shuffle) fix bucket shuffle exchange incorrectly marked as serial in pooling mode#62054924060929 wants to merge 1 commit intoapache:masterfrom
924060929 wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
…s serial in pooling mode 1. ExchangeNode.isSerialOperator(): move useSerialSource() guard into isSerialOperator() so that is_serial is a self-contained per-operator property. Only UNPARTITIONED or use_serial_exchange exchanges in pooling mode are serial. Bucket shuffle / hash exchanges are never serial — scan seriality is handled by the scan pipeline independently. 2. DistributePlanner.filterInstancesWhichCanReceiveDataFromRemote(): use linkNode.isSerialOperator() to decide whether to dedupe to first-per-worker. Remove LocalShuffleAssignedJob type check and enableShareHashTableForBroadcastJoin parameter — serial exchange semantics already capture the correct behavior. 3. Add unit tests for both changes.
e935b63 to
4c3e765
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExchangeNode.isSerialOperator(): move useSerialSource() guard into isSerialOperator()
so that is_serial is a self-contained per-operator property. Only UNPARTITIONED or
use_serial_exchange exchanges in pooling mode are serial. Bucket shuffle / hash
exchanges are never serial — scan seriality is handled by the scan pipeline independently.
DistributePlanner.filterInstancesWhichCanReceiveDataFromRemote(): use
linkNode.isSerialOperator() to decide whether to dedupe to first-per-worker.
Remove LocalShuffleAssignedJob type check and enableShareHashTableForBroadcastJoin
parameter — serial exchange semantics already capture the correct behavior.
Add unit tests for both changes.
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)