Skip to content

branch-4.1: [fix](job) fix StreamingInsertJob incorrectly counting canceled tasks #61894 #62055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
github-actions wants to merge 1 commit into
base: branch-4.1
Choose a base branch
from
+8 −1
Open

branch-4.1: [fix](job) fix StreamingInsertJob incorrectly counting canceled tasks #61894 #62055

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ...re/src/main/java/org/apache/doris/job/extensions/insert/streaming/StreamingInsertJob.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,8 +437,15 @@ public void cancelAllTasks(boolean needWaitCancelComplete) throws JobException {
if (runningStreamTask == null) {
return;
}
// Check status before cancel: if the task was still active (RUNNING or PENDING),
// count it as canceled. If already in a terminal state (e.g. FAILED), it was
// already counted by onStreamTaskFail(), so skip to avoid double-counting.
boolean wasActive = TaskStatus.RUNNING.equals(runningStreamTask.getStatus())
|| TaskStatus.PENDING.equals(runningStreamTask.getStatus());
runningStreamTask.cancel(needWaitCancelComplete);
canceledTaskCount.incrementAndGet();
if (wasActive) {
canceledTaskCount.incrementAndGet();
}
} finally {
lock.writeLock().unlock();
}
Expand Down
Loading