[fix](editlog) Remove dead editStream field and guaranteed-NPE getEditLogSize()#62066
Open
dataroaring wants to merge 1 commit intoapache:masterfrom
Open
[fix](editlog) Remove dead editStream field and guaranteed-NPE getEditLogSize()#62066dataroaring wants to merge 1 commit intoapache:masterfrom
dataroaring wants to merge 1 commit intoapache:masterfrom
Conversation
The editStream field (EditLogOutputStream) is declared but never assigned anywhere in the codebase — it is always null. The getEditLogSize() method calls editStream.length(), which will always throw NullPointerException. Remove both the unused field and the guaranteed-to-NPE method.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
There was a problem hiding this comment.
Pull request overview
Removes a dead editStream field and its associated getEditLogSize() method in EditLog, eliminating a guaranteed NullPointerException path and reducing unused API surface.
Changes:
- Deleted the never-assigned
editStreamfield. - Removed
getEditLogSize()which dereferenced the nulleditStream.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code