ci(fmt): add imports-formatter check ci - #880
Merged
Merged
Conversation
marsevilspirit
marked this pull request as draft
August 2, 2025 12:07
marsevilspirit
marked this pull request as ready for review
August 2, 2025 12:13
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds imports-formatter check to the CI pipeline by reorganizing import statements across Go files to follow a standardized grouping convention.
- Restructures all Go import statements into three distinct groups separated by blank lines
- Groups standard library imports, third-party imports, and local project imports according to Go best practices
- Maintains existing functionality while improving code consistency and readability
| greet "github.com/apache/dubbo-go-samples/java_interop/non-protobuf-triple/proto" | ||
| ) | ||
|
|
||
| // java_math "github.com/dubbogo/gost/math/big" |
There was a problem hiding this comment.
Commented-out import should be removed rather than kept as a comment. If it's needed for future use, consider using a proper TODO comment or removing it entirely.
Suggested change
| // java_math "github.com/dubbogo/gost/math/big" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add imports-formatter check ci.