HIVE-29331 Remove code where MAPRED_MIN_SPLIT_SIZE value is deciding …#6206
Closed
vikramahuja1001 wants to merge 1 commit intoapache:masterfrom
Closed
HIVE-29331 Remove code where MAPRED_MIN_SPLIT_SIZE value is deciding …#6206vikramahuja1001 wants to merge 1 commit intoapache:masterfrom
vikramahuja1001 wants to merge 1 commit intoapache:masterfrom
Conversation
…split size in case of Tez
|
| TezMapReduceSplitsGrouper.TEZ_GROUPING_SPLIT_MIN_SIZE, | ||
| TezMapReduceSplitsGrouper.TEZ_GROUPING_SPLIT_MIN_SIZE_DEFAULT); | ||
| final long preferredSplitSize = Math.min(blockSize / 2, minGrouping); | ||
| HiveConf.setLongVar(jobConf, HiveConf.ConfVars.MAPRED_MIN_SPLIT_SIZE, preferredSplitSize); |
Contributor
There was a problem hiding this comment.
Shouldn't the same config be removed from Line 312 as well?
Member
There was a problem hiding this comment.
MAPRED_MIN_SPLIT_SIZE is being calculated only when not explicitly set by user. I don't follow the change here
HIVE-10746: Hive 1.2.0+Tez produces 1-byte FileSplits from mapred.TextInputFormat
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…split size in case of Tez
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?