HTTP/2 requester: add request submission policy for per-connection #594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quest cap Provide optional queuing mode and keep default fail-fast rejection semantics Derive request scheme from target host to ensure HTTP/2 :scheme is always set
arturobernalg
force-pushed
the
h2-max-requests-policy
branch
from
a94d5d6 to
48d5380
Compare
Member
|
@arturobernalg In my opinion this is an advanced client feature and it should be in the client project, not core. I also think this should be a continuation of apache/httpcomponents-client@ee6ebee. I think there should be just one queue per client instance. Requests that cannot be executed should be put at the end of the queue and re-executed when there total number of concurrent requests drops below the max limit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change extends the per-connection pending request cap in H2MultiplexingRequester with an optional submission policy. The default behavior remains fail-fast rejection with RejectedExecutionException, preserving existing semantics.